diff options
| author |  halcanary <halcanary@google.com> | 2016-08-11 13:59:18 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-08-11 13:59:19 -0700 |
| commit | 5bf60adaaf76a102514b420a4acff6083902dabc (patch) | |
| tree | 167023fceb92caf2c5d59cb4b5c4fac68ec52d05 /src/pdf/SkPDFTypes.cpp | |
| parent | 637b3bf2b9c10398d823bd015a722842d4f2f971 (diff) | |
Revert of SkPDF: Subset Type3 (fallback) font (patchset #8 id:200001 of https://codereview.chromium.org/2231483002/ )
Reason for revert:
internal failing
Original issue's description:
> SkPDF: Subset Type3 (fallback) font
>
> Motivation: significant file-size reduction.
>
> Also: SkPDFFont::subsetFont() returns a sk_sp<SkPDFObject>
> rather than a SkPDFFont*.
>
> SkPDFType3Font constructor no longer populates font info;
> relies on subsetting.
>
> SkPDFFont::Create is easier to read
>
> Also: SkPDFType3Font are scaled by emSize rather than 1000.
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231483002
>
> Committed: https://skia.googlesource.com/skia/+/88b138da99328b04cae9a8ee19c3882b8847a550
TBR=bungeman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2232283003
Diffstat (limited to 'src/pdf/SkPDFTypes.cpp')
| -rw-r--r-- | src/pdf/SkPDFTypes.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/pdf/SkPDFTypes.cpp b/src/pdf/SkPDFTypes.cpp index 6bf6afc611..afb9b72c54 100644 --- a/src/pdf/SkPDFTypes.cpp +++ b/src/pdf/SkPDFTypes.cpp @@ -573,9 +573,7 @@ void SkPDFStream::setData(std::unique_ptr<SkStreamAsset> stream) { SkASSERT(stream->hasLength()); SkDynamicMemoryWStream compressedData; SkDeflateWStream deflateWStream(&compressedData); - if (stream->getLength() > 0) { - SkStreamCopy(&deflateWStream, stream.get()); - } + SkStreamCopy(&deflateWStream, stream.get()); deflateWStream.finalize(); size_t compressedLength = compressedData.bytesWritten(); size_t originalLength = stream->getLength(); |