diff options
author | caryclark <caryclark@google.com> | 2014-06-18 07:24:19 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-06-18 07:24:19 -0700 |
commit | e4097e3a0b10bb0047a45b6949ca01826f0807a7 (patch) | |
tree | 1b04df78fa4a4aa239d09184e88929102d12886a /src/pathops/SkOpSegment.h | |
parent | 683e90611c8a536c3c5feedea27bbbefedf746d2 (diff) |
Fix last pathops skp bug
This fixes the last bug discovered by iterating through the 800K
skp corpus representing the top 1M websites. For every clip on the
stack, the paths are replaced with the pathop intersection. The
resulting draw is compared with the original draw for pixel errors.
At least two prominent bugs remain. In one, the winding value is
confused by a cubic with an inflection. In the other, a quad/cubic
pair, nearly coincident, fails to find an intersection.
These minor changes include ignoring very tiny self-intersections
of cubics, and processing degenerate edges that don't connect to
anything else.
R=reed@android.com
TBR=reed
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/340103002
Diffstat (limited to 'src/pathops/SkOpSegment.h')
-rw-r--r-- | src/pathops/SkOpSegment.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/pathops/SkOpSegment.h b/src/pathops/SkOpSegment.h index 90ed553bd3..d191e88af2 100644 --- a/src/pathops/SkOpSegment.h +++ b/src/pathops/SkOpSegment.h @@ -423,7 +423,7 @@ private: int checkSetAngle(int tIndex) const; void checkSmallCoincidence(const SkOpSpan& span, SkTArray<MissingSpan, true>* ); bool coincidentSmall(const SkPoint& pt, double t, const SkOpSegment* other) const; - bool clockwise(int tStart, int tEnd) const; + bool clockwise(int tStart, int tEnd, bool* swap) const; static void ComputeOneSum(const SkOpAngle* baseAngle, SkOpAngle* nextAngle, SkOpAngle::IncludeType ); static void ComputeOneSumReverse(const SkOpAngle* baseAngle, SkOpAngle* nextAngle, |