diff options
| author |  mtklein <mtklein@chromium.org> | 2015-08-10 12:58:17 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-08-10 12:58:17 -0700 |
| commit | 4977983510028712528743aa877f6da83781b381 (patch) | |
| tree | d56b58c866da7e86a80b38d0e85f03abd3f7d87c /src/opts/SkBlitRow_opts_SSE2.h | |
| parent | c699873ac7c6b21bbca96053cdb9720c80f69916 (diff) | |
Sk4px blit mask.
Local SKP nanobenching ranges SSE between 1.05x and 0.87x, much more heavily weighted toward <1.0x ratios (speedups).
I profiled the top five regressions (1.05x-1.01x) and they look like noise. Will follow up after broad bot results.
NEON looks similar but less extreme than SSE changes, ranging between 1.02x and 0.95x, again mostly speedups in 0.99x-0.97x range.
The old code trifurcated into black, opaque-but-not-black, and general versions as a function of the constant src color. I did not see a significant difference between general and opaque-but-not-black, and I don't think a black version would be faster using SIMD. So we have here just one version of the code, the general version.
Somewhat fantastically, I see no pixel diffs on GMs or SKPs.
I will be following up with more CLs for the other procs called by SkBlitMask.
BUG=skia:
Review URL: https://codereview.chromium.org/1278253003
Diffstat (limited to 'src/opts/SkBlitRow_opts_SSE2.h')
| -rw-r--r-- | src/opts/SkBlitRow_opts_SSE2.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/opts/SkBlitRow_opts_SSE2.h b/src/opts/SkBlitRow_opts_SSE2.h index 6c0611f49f..560edf4923 100644 --- a/src/opts/SkBlitRow_opts_SSE2.h +++ b/src/opts/SkBlitRow_opts_SSE2.h @@ -25,10 +25,6 @@ void S32A_Blend_BlitRow32_SSE2(SkPMColor* SK_RESTRICT dst, void Color32A_D565_SSE2(uint16_t dst[], SkPMColor src, int count, int x, int y); -void SkARGB32_A8_BlitMask_SSE2(void* device, size_t dstRB, const void* mask, - size_t maskRB, SkColor color, - int width, int height); - void SkBlitLCD16Row_SSE2(SkPMColor dst[], const uint16_t src[], SkColor color, int width, SkPMColor); void SkBlitLCD16OpaqueRow_SSE2(SkPMColor dst[], const uint16_t src[], |