diff options
| author |  mtklein <mtklein@chromium.org> | 2015-11-17 12:05:57 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-11-17 12:05:57 -0800 |
| commit | f769c1f80e12e595885376a03f1b99918f2fcd56 (patch) | |
| tree | 847af27cc6a7e31e18d9982ccf5c0cf15232ffe8 /src/opts/Sk4px_SSE2.h | |
| parent | 32d6b876163580711a07e96d9f29c9c1490a7271 (diff) | |
trim some fat from SSE2 fixed point alpha code
- extract alpha from a pixel: 5 1-cycle ops to 4 1-cycle ops
- load alphas: drop 4 unnecessary ops
Should be no pixel diffs.
BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1447273004
Diffstat (limited to 'src/opts/Sk4px_SSE2.h')
| -rw-r--r-- | src/opts/Sk4px_SSE2.h | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/opts/Sk4px_SSE2.h b/src/opts/Sk4px_SSE2.h index 5e97abf308..9c3eb1210c 100644 --- a/src/opts/Sk4px_SSE2.h +++ b/src/opts/Sk4px_SSE2.h @@ -63,18 +63,17 @@ inline Sk4px Sk4px::Wide::addNarrowHi(const Sk16h& other) const { #else inline Sk4px Sk4px::alphas() const { static_assert(SK_A32_SHIFT == 24, "Intel's always little-endian."); - __m128i as = _mm_srli_epi32(this->fVec, 24); // ___3 ___2 ___1 ___0 - as = _mm_or_si128(as, _mm_slli_si128(as, 1)); // __33 __22 __11 __00 - as = _mm_or_si128(as, _mm_slli_si128(as, 2)); // 3333 2222 1111 0000 + // We exploit that A >= rgb for any premul pixel. + __m128i as = fVec; // 3xxx 2xxx 1xxx 0xxx + as = _mm_max_epu8(as, _mm_srli_epi32(as, 8)); // 33xx 22xx 11xx 00xx + as = _mm_max_epu8(as, _mm_srli_epi32(as, 16)); // 3333 2222 1111 0000 return Sk16b(as); } inline Sk4px Sk4px::Load4Alphas(const SkAlpha a[4]) { __m128i as = _mm_cvtsi32_si128(*(const uint32_t*)a); // ____ ____ ____ 3210 - as = _mm_unpacklo_epi8 (as, _mm_setzero_si128()); // ____ ____ _3_2 _1_0 - as = _mm_unpacklo_epi16(as, _mm_setzero_si128()); // ___3 ___2 ___1 ___0 - as = _mm_or_si128(as, _mm_slli_si128(as, 1)); // __33 __22 __11 __00 - as = _mm_or_si128(as, _mm_slli_si128(as, 2)); // 3333 2222 1111 0000 + as = _mm_unpacklo_epi8 (as, as); // ____ ____ 3322 1100 + as = _mm_unpacklo_epi16(as, as); // 3333 2222 1111 0000 return Sk16b(as); } #endif |