diff options
author | Mike Klein <mtklein@chromium.org> | 2017-08-28 12:18:26 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-08-28 17:40:36 +0000 |
commit | d6e12862f08e4fb6491f350d01e24bc907817569 (patch) | |
tree | 8d0b0e6a9caa7dd455ecb872887f9ff70209dda3 /src/jumper/SkJumper_misc.h | |
parent | 2e86634ae64ac333100d55a49992143fbf143384 (diff) |
split up JUMPER define
Whether JUMPER is defined is starting to get a little overloaded:
- are we compiling offline (defined) or as part of Skia (!defined)?
- are we using Clang vector extensions (defined) or scalars (!defined)?
This splits JUMPER into these two separate concerns:
- JUMPER_IS_OFFLINE
- JUMPER_IS_SCALAR, JUMPER_IS_NEON, JUMPER_IS_AVX2, etc.
The upshot is that we'll now use Clang vector extensions when available
for our "portable" baseline. On x86-64 and ARMv8 compiled by Clang,
we're guaranteed to pick up SSE2 and NEON respectively. Our -Fast
bot should even get all the way to AVX2.
Another CL will do some refactoring in SkJumper to remove the redundant
copies of guaranteed vector code on x86-64 and ARMv8. I didn't want to
do that here yet to demonstrate that there is zero effect on the .S
files from this CL.
Change-Id: Ib5e8f00b35e8721b2cc7180e294840ffaf9dddce
Reviewed-on: https://skia-review.googlesource.com/39500
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'src/jumper/SkJumper_misc.h')
-rw-r--r-- | src/jumper/SkJumper_misc.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/jumper/SkJumper_misc.h b/src/jumper/SkJumper_misc.h index 8d7bfeb833..09758fba7d 100644 --- a/src/jumper/SkJumper_misc.h +++ b/src/jumper/SkJumper_misc.h @@ -13,7 +13,7 @@ // Miscellany used by SkJumper_stages.cpp and SkJumper_vectors.h. // Every function in this file should be marked static and inline using SI. -#if defined(JUMPER) +#if defined(JUMPER_IS_OFFLINE) #define SI __attribute__((always_inline)) static inline #else #define SI static inline |