diff options
| author |  Mike Klein <mtklein@chromium.org> | 2017-05-01 16:01:38 -0400 |
|---|---|---|
| committer | Mike Klein <mtklein@chromium.org> | 2017-05-01 20:59:45 +0000 |
| commit | 5664e65eb1680a14eeaa6ca79ddf9e734518c822 (patch) | |
| tree | ee66d340b7acce5ef99a1296108981862dbf962d /src/jumper/SkJumper.h | |
| parent | 879a08ac146acb2518363cc9d2d8aa6dce04528d (diff) | |
finish up constants
For whatever reason, if I swap the condition in the if_then_else tests
from < to >= and swap the then/else values, I can use constants in
hsl_to_rgb. Still don't understand why, but I'll take it. I suspect it
has something to do with SSE, IEEE, and NaN, but I don't care enough to
speculate any more concretely.
This does that, removes C() and _f, updates some comments, and adds a
guard in build_stages.py to yell if it sees trouble like LCPI40_4...
This reminds me to try -ffast-math soon. I think that was mostly held
back by constants.
Change-Id: I3f8a37a4d4642f77422ce3261b750061e9e604a3
Reviewed-on: https://skia-review.googlesource.com/14942
Reviewed-by: Herb Derby <herb@google.com>
Diffstat (limited to 'src/jumper/SkJumper.h')
| -rw-r--r-- | src/jumper/SkJumper.h | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/src/jumper/SkJumper.h b/src/jumper/SkJumper.h index 1dc0fc4cdd..cd164fe913 100644 --- a/src/jumper/SkJumper.h +++ b/src/jumper/SkJumper.h @@ -48,17 +48,6 @@ #include <stdint.h> #endif -// SkJumper_stages.cpp has some unusual constraints on what constants it can use. -// -// If the constant is baked into the instruction, that's ok. -// If the constant is synthesized through code, that's ok. -// If the constant is loaded from memory, that's no good. -// -// We offer a couple facilities to get at any other constants you need: -// - the C() function usually constrains constants to be directly baked into an instruction; or -// - the _i and _f user-defined literal operators call C() for you in a prettier way; or -// - you can load values from this struct. - static const int SkJumper_kMaxStride = 8; struct SkJumper_constants { |