diff options
| author |  Chris Dalton <csmartdalton@google.com> | 2018-03-29 12:34:41 -0600 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-03-29 19:05:46 +0000 |
| commit | 03616574024a7f321e885e5ab6fc575746573109 (patch) | |
| tree | 3978413113eee8a9baffc6f8b1e1851150c5bd19 /src/gpu/vk/GrVkCaps.cpp | |
| parent | 9329689045012aed43e973baf40d33185a2add2d (diff) | |
vulkan: Blacklist MSAA path renderer on Qualcomm drivers
Bug: skia:7758
Change-Id: I96b5c259352949d67f5e0263a7164cdce54b3269
Reviewed-on: https://skia-review.googlesource.com/117152
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Diffstat (limited to 'src/gpu/vk/GrVkCaps.cpp')
| -rw-r--r-- | src/gpu/vk/GrVkCaps.cpp | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/src/gpu/vk/GrVkCaps.cpp b/src/gpu/vk/GrVkCaps.cpp index 83546da5c4..aa93f2e561 100644 --- a/src/gpu/vk/GrVkCaps.cpp +++ b/src/gpu/vk/GrVkCaps.cpp @@ -131,6 +131,10 @@ void GrVkCaps::applyDriverCorrectnessWorkarounds(const VkPhysicalDevicePropertie fNewCBOnPipelineChange = true; } + if (kIntel_VkVendor == properties.vendorID) { + fCanUseWholeSizeOnFlushMappedMemory = false; + } + //////////////////////////////////////////////////////////////////////////// // GrCaps workarounds //////////////////////////////////////////////////////////////////////////// @@ -144,8 +148,14 @@ void GrVkCaps::applyDriverCorrectnessWorkarounds(const VkPhysicalDevicePropertie fMaxVertexAttributes = SkTMin(fMaxVertexAttributes, 32); } - if (kIntel_VkVendor == properties.vendorID) { - fCanUseWholeSizeOnFlushMappedMemory = false; + if (kQualcomm_VkVendor == properties.vendorID) { + // http://skbug.com/7758 -- the bots have a rendering issue related to the MSAA path + // renderer. It doesn't repro locally, and there doesn't seem to be a correlation between it + // and the driver version. Blacklisting across-the-board for now. + // + // properties.driverVersion=93622907, Android 8.1 -> no repro + // properties.driverVersion=159578699, Android 8.0 -> repros + fBlacklistMSAAPathRenderer = true; } //////////////////////////////////////////////////////////////////////////// |