aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/gpu/ops
diff options
context:
space:
mode:
authorGravatar Matt Sarett <msarett@google.com>2017-01-10 17:41:53 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-01-11 14:48:53 +0000
commit34855f9e1c40bf91d2bdbd34b32868eb06327c9f (patch)
tree2416914a83e185d7c4d88db8131bce57ba2444ab /src/gpu/ops
parentf4faccd3b303cd21b6cd3d7b1a54d2b5f0c6f079 (diff)
Add readPixels() tests for generator backed images
Good news: Everything seems to work as it is supposed to. That's why this CL is just tests. Bad news: Picture is a bit strange in that the caching behavior may affect how the output looks. Ex: If we choose to cache, we will first draw into the picture's colorSpace and then convert that to the dstColorSpace. If we choose not to cache, we will draw directly into the dstColorSpace. And then untagged pictures seem like they really shouldn't work very well... We are caching a legacy draw and then drawing that into the dstColorSpace? Maybe this isn't the most critical thing to think about right now though, given Florin's work. Remaining TODOs: Color space support for gpu-backed images. I still plan to clarify conversions that are allowed vs. not allowed and share that code between all SkImages. BUG=skia:6021 Change-Id: I9557ca1c00ff6854848fe59c3a67abd2af91bb46 Reviewed-on: https://skia-review.googlesource.com/6853 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
Diffstat (limited to 'src/gpu/ops')
0 files changed, 0 insertions, 0 deletions