diff options
author | dcheng <dcheng@chromium.org> | 2016-02-06 15:08:54 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-06 15:08:55 -0800 |
commit | c4d196c9c87f226eb33b8091dc50053c45c4e752 (patch) | |
tree | d4850f4715af4c3d5364e311f95fe6524d9a682b /src/gpu/gl/GrGLVertexArray.h | |
parent | 964eec67760196585954203ba625e440607f7e92 (diff) |
Revert of Improve GLSL integer support (patchset #1 id:1 of https://codereview.chromium.org/1669853002/ )
Reason for revert:
MSAN bots are unhappy with this change: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/7068
Original issue's description:
> Improve GLSL integer support
>
> - Adds shader types for uint.
> - Adds a cap for integer support.
> - Uses glVertexAttribIPointer for integer attribs.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1669853002
>
> Committed: https://skia.googlesource.com/skia/+/3a2caf8ecf38124f4ad21a0f6c4dabfcfa17911a
TBR=bsalomon@google.com,egdaniel@google.com,ethannicholas@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1674813004
Diffstat (limited to 'src/gpu/gl/GrGLVertexArray.h')
-rw-r--r-- | src/gpu/gl/GrGLVertexArray.h | 49 |
1 files changed, 41 insertions, 8 deletions
diff --git a/src/gpu/gl/GrGLVertexArray.h b/src/gpu/gl/GrGLVertexArray.h index f5a97672f3..0a5dea6a1e 100644 --- a/src/gpu/gl/GrGLVertexArray.h +++ b/src/gpu/gl/GrGLVertexArray.h @@ -17,6 +17,35 @@ class GrGLVertexBuffer; class GrGLIndexBuffer; class GrGLGpu; +struct GrGLAttribLayout { + GrGLint fCount; + GrGLenum fType; + GrGLboolean fNormalized; +}; + +static inline const GrGLAttribLayout& GrGLAttribTypeToLayout(GrVertexAttribType type) { + static const GrGLAttribLayout kLayouts[kGrVertexAttribTypeCount] = { + {1, GR_GL_FLOAT, false}, // kFloat_GrVertexAttribType + {2, GR_GL_FLOAT, false}, // kVec2f_GrVertexAttribType + {3, GR_GL_FLOAT, false}, // kVec3f_GrVertexAttribType + {4, GR_GL_FLOAT, false}, // kVec4f_GrVertexAttribType + {1, GR_GL_UNSIGNED_BYTE, true}, // kUByte_GrVertexAttribType + {4, GR_GL_UNSIGNED_BYTE, true}, // kVec4ub_GrVertexAttribType + {2, GR_GL_SHORT, false}, // kVec2s_GrVertexAttribType + {4, GR_GL_INT, false}, // kInt_GrVertexAttribType + }; + GR_STATIC_ASSERT(0 == kFloat_GrVertexAttribType); + GR_STATIC_ASSERT(1 == kVec2f_GrVertexAttribType); + GR_STATIC_ASSERT(2 == kVec3f_GrVertexAttribType); + GR_STATIC_ASSERT(3 == kVec4f_GrVertexAttribType); + GR_STATIC_ASSERT(4 == kUByte_GrVertexAttribType); + GR_STATIC_ASSERT(5 == kVec4ub_GrVertexAttribType); + GR_STATIC_ASSERT(6 == kVec2s_GrVertexAttribType); + GR_STATIC_ASSERT(7 == kInt_GrVertexAttribType); + GR_STATIC_ASSERT(SK_ARRAY_COUNT(kLayouts) == kGrVertexAttribTypeCount); + return kLayouts[type]; +} + /** * This sets and tracks the vertex attribute array state. It is used internally by GrGLVertexArray * (below) but is separate because it is also used to track the state of vertex array object 0. @@ -42,7 +71,9 @@ public: void set(GrGLGpu*, int attribIndex, GrGLuint vertexBufferID, - GrVertexAttribType type, + GrGLint size, + GrGLenum type, + GrGLboolean normalized, GrGLsizei stride, GrGLvoid* offset); @@ -84,13 +115,15 @@ private: fAttribPointerIsValid = false; } - bool fEnableIsValid; - bool fAttribPointerIsValid; - bool fEnabled; - GrGLuint fVertexBufferID; - GrVertexAttribType fType; - GrGLsizei fStride; - GrGLvoid* fOffset; + bool fEnableIsValid; + bool fAttribPointerIsValid; + bool fEnabled; + GrGLuint fVertexBufferID; + GrGLint fSize; + GrGLenum fType; + GrGLboolean fNormalized; + GrGLsizei fStride; + GrGLvoid* fOffset; }; SkSTArray<16, AttribArrayState, true> fAttribArrayStates; |