diff options
author | 2017-04-21 10:30:29 -0400 | |
---|---|---|
committer | 2017-04-21 21:15:44 +0000 | |
commit | 2229b576949a76fddb5bc823accfd70e655dea14 (patch) | |
tree | 12fda5ef3d5990e09e12b7cda13b1a4a00b50f73 /src/gpu/gl/GrGLStencilAttachment.h | |
parent | 83239658f2dea7fdfd5d4f11521c0e2a326aa345 (diff) |
jumper, maybe we can just use constants
As long as everything is laid out the same way they were originally, I don't
think there's any reason we can't just use %rip-relative addressing on x86-64.
Basically, we just need to keep all the sections together in order.
Somewhat subtly we cannot just use -D to disassemble all sections. -D will
double-disassemble[1] some bytes, which throws off our %rip-relative addressing
of constants. You can see this in PS1. So we whitelist sections instead.
[1], from man objdump:
This option also has a subtle effect on the disassembly of instructions in code
sections. When option -d is in effect objdump will assume that any symbols
present in a code section occur on the boundary between instructions and it will
refuse to disassemble across such a boundary. When option -D is in effect however
this assumption is supressed. This means that it is possible for the output of -d
and -D to differ if, for example, data is stored in code sections.
Change-Id: Idbcfe08e67113b3f7d75749931c640ff90aa0bf4
Reviewed-on: https://skia-review.googlesource.com/14029
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Diffstat (limited to 'src/gpu/gl/GrGLStencilAttachment.h')
0 files changed, 0 insertions, 0 deletions