diff options
author | 2015-05-19 07:15:28 -0700 | |
---|---|---|
committer | 2015-05-19 07:15:28 -0700 | |
commit | d3a560fa80bfb3e2d2e989f951bb3b1c52316654 (patch) | |
tree | 6702bf0af4281910271596fe9b11316902194d79 /src/gpu/effects/GrBezierEffect.h | |
parent | cbfe91d82500f4ae8c3ff7bd74b3021a4b89fd84 (diff) |
Revert of Preliminary attempt to remove batch tracker (patchset #3 id:40001 of https://codereview.chromium.org/1139723004/)
Reason for revert:
breaking bots
Original issue's description:
> Preliminary attempt to remove batch tracker
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/cbfe91d82500f4ae8c3ff7bd74b3021a4b89fd84
TBR=robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1132323003
Diffstat (limited to 'src/gpu/effects/GrBezierEffect.h')
-rw-r--r-- | src/gpu/effects/GrBezierEffect.h | 33 |
1 files changed, 14 insertions, 19 deletions
diff --git a/src/gpu/effects/GrBezierEffect.h b/src/gpu/effects/GrBezierEffect.h index 7700c58fe6..f1b22fa8a4 100644 --- a/src/gpu/effects/GrBezierEffect.h +++ b/src/gpu/effects/GrBezierEffect.h @@ -63,7 +63,6 @@ public: const GrPrimitiveEdgeType edgeType, const GrDrawTargetCaps& caps, const SkMatrix& localMatrix, - bool usesLocalCoords, uint8_t coverage = 0xff) { switch (edgeType) { case kFillAA_GrProcessorEdgeType: @@ -72,18 +71,18 @@ public: } return SkNEW_ARGS(GrConicEffect, (color, viewMatrix, coverage, kFillAA_GrProcessorEdgeType, - localMatrix, usesLocalCoords)); + localMatrix)); case kHairlineAA_GrProcessorEdgeType: if (!caps.shaderCaps()->shaderDerivativeSupport()) { return NULL; } return SkNEW_ARGS(GrConicEffect, (color, viewMatrix, coverage, kHairlineAA_GrProcessorEdgeType, - localMatrix, usesLocalCoords)); + localMatrix)); case kFillBW_GrProcessorEdgeType: return SkNEW_ARGS(GrConicEffect, (color, viewMatrix, coverage, kFillBW_GrProcessorEdgeType, - localMatrix, usesLocalCoords)); + localMatrix)); default: return NULL; } @@ -99,11 +98,8 @@ public: inline bool isFilled() const { return GrProcessorEdgeTypeIsFill(fEdgeType); } inline GrPrimitiveEdgeType getEdgeType() const { return fEdgeType; } GrColor color() const { return fColor; } - bool colorIgnored() const { return GrColor_ILLEGAL == fColor; } const SkMatrix& viewMatrix() const { return fViewMatrix; } const SkMatrix& localMatrix() const { return fLocalMatrix; } - bool usesLocalCoords() const { return fUsesLocalCoords; } - uint8_t coverageScale() const { return fCoverageScale; } virtual void getGLProcessorKey(const GrBatchTracker& bt, const GrGLSLCaps& caps, @@ -112,14 +108,15 @@ public: virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt, const GrGLSLCaps&) const override; + void initBatchTracker(GrBatchTracker*, const GrPipelineInfo&) const override; + private: GrConicEffect(GrColor, const SkMatrix& viewMatrix, uint8_t coverage, GrPrimitiveEdgeType, - const SkMatrix& localMatrix, bool usesLocalCoords); + const SkMatrix& localMatrix); GrColor fColor; SkMatrix fViewMatrix; SkMatrix fLocalMatrix; - bool fUsesLocalCoords; uint8_t fCoverageScale; GrPrimitiveEdgeType fEdgeType; const Attribute* fInPosition; @@ -148,7 +145,6 @@ public: const GrPrimitiveEdgeType edgeType, const GrDrawTargetCaps& caps, const SkMatrix& localMatrix, - bool usesLocalCoords, uint8_t coverage = 0xff) { switch (edgeType) { case kFillAA_GrProcessorEdgeType: @@ -157,18 +153,18 @@ public: } return SkNEW_ARGS(GrQuadEffect, (color, viewMatrix, coverage, kFillAA_GrProcessorEdgeType, - localMatrix, usesLocalCoords)); + localMatrix)); case kHairlineAA_GrProcessorEdgeType: if (!caps.shaderCaps()->shaderDerivativeSupport()) { return NULL; } return SkNEW_ARGS(GrQuadEffect, (color, viewMatrix, coverage, kHairlineAA_GrProcessorEdgeType, - localMatrix, usesLocalCoords)); + localMatrix)); case kFillBW_GrProcessorEdgeType: return SkNEW_ARGS(GrQuadEffect, (color, viewMatrix, coverage, kFillBW_GrProcessorEdgeType, - localMatrix, usesLocalCoords)); + localMatrix)); default: return NULL; } @@ -184,11 +180,8 @@ public: inline bool isFilled() const { return GrProcessorEdgeTypeIsFill(fEdgeType); } inline GrPrimitiveEdgeType getEdgeType() const { return fEdgeType; } GrColor color() const { return fColor; } - bool colorIgnored() const { return GrColor_ILLEGAL == fColor; } const SkMatrix& viewMatrix() const { return fViewMatrix; } const SkMatrix& localMatrix() const { return fLocalMatrix; } - bool usesLocalCoords() const { return fUsesLocalCoords; } - uint8_t coverageScale() const { return fCoverageScale; } virtual void getGLProcessorKey(const GrBatchTracker& bt, const GrGLSLCaps& caps, @@ -197,14 +190,15 @@ public: virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt, const GrGLSLCaps&) const override; + void initBatchTracker(GrBatchTracker*, const GrPipelineInfo&) const override; + private: GrQuadEffect(GrColor, const SkMatrix& viewMatrix, uint8_t coverage, GrPrimitiveEdgeType, - const SkMatrix& localMatrix, bool usesLocalCoords); + const SkMatrix& localMatrix); GrColor fColor; SkMatrix fViewMatrix; SkMatrix fLocalMatrix; - bool fUsesLocalCoords; uint8_t fCoverageScale; GrPrimitiveEdgeType fEdgeType; const Attribute* fInPosition; @@ -264,7 +258,6 @@ public: inline bool isFilled() const { return GrProcessorEdgeTypeIsFill(fEdgeType); } inline GrPrimitiveEdgeType getEdgeType() const { return fEdgeType; } GrColor color() const { return fColor; } - bool colorIgnored() const { return GrColor_ILLEGAL == fColor; } const SkMatrix& viewMatrix() const { return fViewMatrix; } virtual void getGLProcessorKey(const GrBatchTracker& bt, @@ -274,6 +267,8 @@ public: virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt, const GrGLSLCaps&) const override; + void initBatchTracker(GrBatchTracker*, const GrPipelineInfo&) const override; + private: GrCubicEffect(GrColor, const SkMatrix& viewMatrix, GrPrimitiveEdgeType); |