diff options
author | Greg Daniel <egdaniel@google.com> | 2018-06-07 20:11:27 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-06-07 20:11:33 +0000 |
commit | 0c78238e2991c95b6fb3c945d4ad2b5d941ae21b (patch) | |
tree | 4810fb4c78687a0100b847188ab27c804fcd1d56 /src/gpu/GrTextureAdjuster.cpp | |
parent | 1bd4b31d1d56533686c3ab9ee1c4cbbb1978d4e3 (diff) |
Revert "Require mips to be allocated at texture creation time and disable late allocations."
This reverts commit cd2c3f9055452d413d6be7ea6dc63fd1922fe994.
Reason for revert: Looks to be causing angle failures on initial clear test
Original change's description:
> Require mips to be allocated at texture creation time and disable late allocations.
>
> If we get a non-mipped texture for a draw that wants to be use mip map filter, we
> will copy the texture into a new mipped texture.
>
> Clean up of unused code in the GPU backends for reallocating for mips will be done
> in a follow up CL.
>
> Bug: skia:
> Change-Id: Idab588c1abf4bbbf7eeceb3727d500e5df274188
> Reviewed-on: https://skia-review.googlesource.com/132830
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>
TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com
Change-Id: I49f0ace52f2586d61b451630b2e6aae84b420b81
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/133041
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Diffstat (limited to 'src/gpu/GrTextureAdjuster.cpp')
-rw-r--r-- | src/gpu/GrTextureAdjuster.cpp | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/src/gpu/GrTextureAdjuster.cpp b/src/gpu/GrTextureAdjuster.cpp index 59dd7f5d59..cc61533044 100644 --- a/src/gpu/GrTextureAdjuster.cpp +++ b/src/gpu/GrTextureAdjuster.cpp @@ -43,11 +43,10 @@ sk_sp<GrTextureProxy> GrTextureAdjuster::refTextureProxyCopy(const CopyParams& c GrUniqueKey key; this->makeCopyKey(copyParams, &key, nullptr); - sk_sp<GrTextureProxy> cachedCopy; if (key.isValid()) { - cachedCopy = proxyProvider->findOrCreateProxyByUniqueKey(key, - this->originalProxy()->origin()); - if (cachedCopy && (!willBeMipped || GrMipMapped::kYes == cachedCopy->mipMapped())) { + sk_sp<GrTextureProxy> cachedCopy = + proxyProvider->findOrCreateProxyByUniqueKey(key, this->originalProxy()->origin()); + if (cachedCopy) { return cachedCopy; } } @@ -58,14 +57,6 @@ sk_sp<GrTextureProxy> GrTextureAdjuster::refTextureProxyCopy(const CopyParams& c if (copy) { if (key.isValid()) { SkASSERT(copy->origin() == this->originalProxy()->origin()); - if (cachedCopy) { - SkASSERT(GrMipMapped::kYes == copy->mipMapped() && - GrMipMapped::kNo == cachedCopy->mipMapped()); - // If we had a cachedProxy, that means there already is a proxy in the cache which - // matches the key, but it does not have mip levels and we require them. Thus we - // must remove the unique key from that proxy. - proxyProvider->removeUniqueKeyFromProxy(key, cachedCopy.get()); - } proxyProvider->assignUniqueKeyToProxy(key, copy.get()); this->didCacheCopy(key); } |