diff options
author | Greg Daniel <egdaniel@google.com> | 2017-10-23 16:05:23 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-10-23 20:25:59 +0000 |
commit | e252f08982b0c747cd4d34c00ce413ab1005e99a (patch) | |
tree | 1fde0a4ac30cf4dc1fc752ef39fc2a0b905be210 /src/gpu/GrRenderTargetProxy.cpp | |
parent | 33397f279393a33eff8e32d47fc56be86b86c9bc (diff) |
Add hint to SkSurface::MakeRenderTarget that we will use mips
Additionally this changed triggered a cascade of plumbing GrMipMapped
down throughout Ganesh.
Bug: skia:
Change-Id: I4181f44d9046d66139bb491c7abf86703305aaeb
Reviewed-on: https://skia-review.googlesource.com/63000
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Diffstat (limited to 'src/gpu/GrRenderTargetProxy.cpp')
-rw-r--r-- | src/gpu/GrRenderTargetProxy.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/gpu/GrRenderTargetProxy.cpp b/src/gpu/GrRenderTargetProxy.cpp index 77a3e52c2a..9453ce8204 100644 --- a/src/gpu/GrRenderTargetProxy.cpp +++ b/src/gpu/GrRenderTargetProxy.cpp @@ -52,11 +52,12 @@ bool GrRenderTargetProxy::instantiate(GrResourceProvider* resourceProvider) { static constexpr GrSurfaceFlags kFlags = kRenderTarget_GrSurfaceFlag; if (!this->instantiateImpl(resourceProvider, fSampleCnt, fNeedsStencil, kFlags, - /* isMipped = */ false, + GrMipMapped::kNo, SkDestinationSurfaceColorMode::kLegacy, nullptr)) { return false; } SkASSERT(fTarget->asRenderTarget()); + SkASSERT(!fTarget->asTexture()); // Check that our a priori computation matched the ultimate reality SkASSERT(fRenderTargetFlags == fTarget->asRenderTarget()->renderTargetPriv().flags()); @@ -67,12 +68,13 @@ sk_sp<GrSurface> GrRenderTargetProxy::createSurface(GrResourceProvider* resource static constexpr GrSurfaceFlags kFlags = kRenderTarget_GrSurfaceFlag; sk_sp<GrSurface> surface = this->createSurfaceImpl(resourceProvider, fSampleCnt, fNeedsStencil, - kFlags, /* isMipped = */ false, + kFlags, GrMipMapped::kNo, SkDestinationSurfaceColorMode::kLegacy); if (!surface) { return nullptr; } SkASSERT(surface->asRenderTarget()); + SkASSERT(!surface->asTexture()); // Check that our a priori computation matched the ultimate reality SkASSERT(fRenderTargetFlags == surface->asRenderTarget()->renderTargetPriv().flags()); @@ -81,8 +83,9 @@ sk_sp<GrSurface> GrRenderTargetProxy::createSurface(GrResourceProvider* resource size_t GrRenderTargetProxy::onUninstantiatedGpuMemorySize() const { int colorSamplesPerPixel = this->numColorSamples() + 1; + // TODO: do we have enough information to improve this worst case estimate? - return GrSurface::ComputeSize(fConfig, fWidth, fHeight, colorSamplesPerPixel, false, + return GrSurface::ComputeSize(fConfig, fWidth, fHeight, colorSamplesPerPixel, GrMipMapped::kNo, SkBackingFit::kApprox == fFit); } |