diff options
author | 2017-03-16 19:51:42 +0000 | |
---|---|---|
committer | 2017-03-16 19:51:55 +0000 | |
commit | c48af934608bbb65650641f66adb51f2102d4274 (patch) | |
tree | 7853ab4fc62a179b8192a5c25db3472dd5fe6b9a /src/gpu/GrRenderTargetContext.h | |
parent | a839fc0b63bd68682dcf51abc77078bfea48c1a1 (diff) |
Revert "Remove GrPipeline from GrDrawOp."
This reverts commit 2bf4b3a97b770811d9e0558dbbfbdb57cfafbdb7.
Reason for revert: nanobench assertion
Original change's description:
> Remove GrPipeline from GrDrawOp.
>
> GrDrawOp subclasses are now free to construct their pipelines at flush time and now in theory could use multiple GrPipelines for multipass rendering.
>
> GrProcessorSet may be used to retain the processors from a GrPaint with "pending execution" style refs.
>
> NVPR and Instanced rendering are updated to create their pipelines at flush time without a GrPipelineBuilder.
>
> The monolithic pipeline creation/management that was on GrDrawOp is moved to GrMeshDrawOp. However, this is temporary and will be removed in coming changes.
>
> Change-Id: I124282e3cea5d070970b5460c8a679fcaf7a8eff
> Reviewed-on: https://skia-review.googlesource.com/7279
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
>
TBR=bsalomon@google.com,robertphillips@google.com,csmartdalton@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I1bc64f6cbbd5f482417637a034342c2b5371dc5c
Reviewed-on: https://skia-review.googlesource.com/9817
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Diffstat (limited to 'src/gpu/GrRenderTargetContext.h')
-rw-r--r-- | src/gpu/GrRenderTargetContext.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/gpu/GrRenderTargetContext.h b/src/gpu/GrRenderTargetContext.h index 8b07c22bd2..c6793d3a82 100644 --- a/src/gpu/GrRenderTargetContext.h +++ b/src/gpu/GrRenderTargetContext.h @@ -22,8 +22,8 @@ class GrClip; class GrDrawingManager; class GrDrawOp; class GrFixedClip; -class GrMeshDrawOp; class GrPipelineBuilder; +class GrMeshDrawOp; class GrRenderTarget; class GrRenderTargetContextPriv; class GrRenderTargetOpList; @@ -478,8 +478,9 @@ private: // These perform processing specific to Gr[Mesh]DrawOp-derived ops before recording them into // the op list. They return the id of the opList to which the op was added, or 0, if it was // dropped (e.g., due to clipping). - uint32_t addDrawOp(const GrClip&, std::unique_ptr<GrDrawOp>); - uint32_t addMeshDrawOp(const GrPipelineBuilder&, const GrClip&, std::unique_ptr<GrMeshDrawOp>); + uint32_t addDrawOp(const GrPipelineBuilder&, const GrClip&, std::unique_ptr<GrDrawOp>); + uint32_t addMeshDrawOp(const GrPipelineBuilder&, const GrClip&, + std::unique_ptr<GrMeshDrawOp> op); // Makes a copy of the dst if it is necessary for the draw and returns the texture that should // be used by GrXferProcessor to access the destination color. If the texture is nullptr then |