Revert of Replace GrStrokeInfo with GrStyle. (patchset #4 id:160001 of https://codereview.chromium.org/1957363002/ )

Reason for revert:
Breaking some bots

Original issue's description:
> Replace GrStrokeInfo with GrStyle.
>
> A side effect is that arbitrary path effects can no be pushed deeper into the Ganesh flow for paths. They may be applied by path renderers.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957363002
>
> Committed: https://skia.googlesource.com/skia/+/33595bdf4b64a745f6340338d307e806e96c587f

TBR=egdaniel@google.com,robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/1967513002

1 files changed, 30 insertions, 56 deletions

diff --git a/src/gpu/GrPath.cpp b/src/gpu/GrPath.cpp
index 91a245d854..04d93b10ae 100644
--- a/src/gpu/GrPath.cpp
+++ b/src/gpu/GrPath.cpp
@@ -6,28 +6,13 @@
  */
 
 #include "GrPath.h"
-#include "GrStyle.h"
 
 namespace {
 // Verb count limit for generating path key from content of a volatile path.
 // The value should accomodate at least simple rects and rrects.
 static const int kSimpleVolatilePathVerbLimit = 10;
 
-static inline int style_data_cnt(const GrStyle& style) {
-    int cnt = GrStyle::KeySize(style, GrStyle::Apply::kPathEffectAndStrokeRec);
-    // This should only fail for an arbitrary path effect, and we should not have gotten
-    // here with anything other than a dash path effect.
-    SkASSERT(cnt >= 0);
-    return cnt;
-}
-
-static inline void write_style_key(uint32_t* dst, const GrStyle& style) {
-    // Pass 1 for the scale since the GPU will apply the style not GrStyle::applyToPath().
-    GrStyle::WriteKey(dst, style, GrStyle::Apply::kPathEffectAndStrokeRec, SK_Scalar1);
-}
-
-
-inline static bool compute_key_for_line_path(const SkPath& path, const GrStyle& style,
+inline static bool compute_key_for_line_path(const SkPath& path, const GrStrokeInfo& stroke,
                                              GrUniqueKey* key) {
     SkPoint pts[2];
     if (!path.isLine(pts)) {
@@ -35,37 +20,37 @@ inline static bool compute_key_for_line_path(const SkPath& path, const GrStyle&
     }
     static_assert((sizeof(pts) % sizeof(uint32_t)) == 0 && sizeof(pts) > sizeof(uint32_t),
                   "pts_needs_padding");
-    int styleDataCnt = style_data_cnt(style);
 
     const int kBaseData32Cnt = 1 + sizeof(pts) / sizeof(uint32_t);
+    int strokeDataCnt = stroke.computeUniqueKeyFragmentData32Cnt();
     static const GrUniqueKey::Domain kOvalPathDomain = GrUniqueKey::GenerateDomain();
-    GrUniqueKey::Builder builder(key, kOvalPathDomain, kBaseData32Cnt + styleDataCnt);
+    GrUniqueKey::Builder builder(key, kOvalPathDomain, kBaseData32Cnt + strokeDataCnt);
     builder[0] = path.getFillType();
     memcpy(&builder[1], &pts, sizeof(pts));
-    if (styleDataCnt > 0) {
-        write_style_key(&builder[kBaseData32Cnt], style);
+    if (strokeDataCnt > 0) {
+        stroke.asUniqueKeyFragment(&builder[kBaseData32Cnt]);
     }
     return true;
 }
 
-inline static bool compute_key_for_oval_path(const SkPath& path, const GrStyle& style,
+inline static bool compute_key_for_oval_path(const SkPath& path, const GrStrokeInfo& stroke,
                                              GrUniqueKey* key) {
     SkRect rect;
     // Point order is significant when dashing, so we cannot devolve to a rect key.
-    if (style.pathEffect() || !path.isOval(&rect)) {
+    if (stroke.isDashed() || !path.isOval(&rect)) {
         return false;
     }
     static_assert((sizeof(rect) % sizeof(uint32_t)) == 0 && sizeof(rect) > sizeof(uint32_t),
                   "rect_needs_padding");
 
     const int kBaseData32Cnt = 1 + sizeof(rect) / sizeof(uint32_t);
-    int styleDataCnt = style_data_cnt(style);
+    int strokeDataCnt = stroke.computeUniqueKeyFragmentData32Cnt();
     static const GrUniqueKey::Domain kOvalPathDomain = GrUniqueKey::GenerateDomain();
-    GrUniqueKey::Builder builder(key, kOvalPathDomain, kBaseData32Cnt + styleDataCnt);
+    GrUniqueKey::Builder builder(key, kOvalPathDomain, kBaseData32Cnt + strokeDataCnt);
     builder[0] = path.getFillType();
     memcpy(&builder[1], &rect, sizeof(rect));
-    if (styleDataCnt > 0) {
-        write_style_key(&builder[kBaseData32Cnt], style);
+    if (strokeDataCnt > 0) {
+        stroke.asUniqueKeyFragment(&builder[kBaseData32Cnt]);
     }
     return true;
 }
@@ -73,7 +58,7 @@ inline static bool compute_key_for_oval_path(const SkPath& path, const GrStyle&
 // Encodes the full path data to the unique key for very small, volatile paths. This is typically
 // hit when clipping stencils the clip stack. Intention is that this handles rects too, since
 // SkPath::isRect seems to do non-trivial amount of work.
-inline static bool compute_key_for_simple_path(const SkPath& path, const GrStyle& style,
+inline static bool compute_key_for_simple_path(const SkPath& path, const GrStrokeInfo& stroke,
                                                GrUniqueKey* key) {
     if (!path.isVolatile()) {
         return false;
@@ -124,9 +109,9 @@ inline static bool compute_key_for_simple_path(const SkPath& path, const GrStyle
     // 2) stroke data (varying size)
 
     const int baseData32Cnt = 2 + verbData32Cnt + pointData32Cnt + conicWeightData32Cnt;
-    const int styleDataCnt = style_data_cnt(style);
+    const int strokeDataCnt = stroke.computeUniqueKeyFragmentData32Cnt();
     static const GrUniqueKey::Domain kSimpleVolatilePathDomain = GrUniqueKey::GenerateDomain();
-    GrUniqueKey::Builder builder(key, kSimpleVolatilePathDomain, baseData32Cnt + styleDataCnt);
+    GrUniqueKey::Builder builder(key, kSimpleVolatilePathDomain, baseData32Cnt + strokeDataCnt);
     int i = 0;
     builder[i++] = path.getFillType();
 
@@ -168,68 +153,57 @@ inline static bool compute_key_for_simple_path(const SkPath& path, const GrStyle
         SkDEBUGCODE(i += conicWeightData32Cnt);
     }
     SkASSERT(i == baseData32Cnt);
-    if (styleDataCnt > 0) {
-        write_style_key(&builder[baseData32Cnt], style);
+    if (strokeDataCnt > 0) {
+        stroke.asUniqueKeyFragment(&builder[baseData32Cnt]);
     }
     return true;
 }
 
-inline static void compute_key_for_general_path(const SkPath& path, const GrStyle& style,
+inline static void compute_key_for_general_path(const SkPath& path, const GrStrokeInfo& stroke,
                                                 GrUniqueKey* key) {
     const int kBaseData32Cnt = 2;
-    int styleDataCnt = style_data_cnt(style);
+    int strokeDataCnt = stroke.computeUniqueKeyFragmentData32Cnt();
     static const GrUniqueKey::Domain kGeneralPathDomain = GrUniqueKey::GenerateDomain();
-    GrUniqueKey::Builder builder(key, kGeneralPathDomain, kBaseData32Cnt + styleDataCnt);
+    GrUniqueKey::Builder builder(key, kGeneralPathDomain, kBaseData32Cnt + strokeDataCnt);
     builder[0] = path.getGenerationID();
     builder[1] = path.getFillType();
-    if (styleDataCnt > 0) {
-        write_style_key(&builder[kBaseData32Cnt], style);
+    if (strokeDataCnt > 0) {
+        stroke.asUniqueKeyFragment(&builder[kBaseData32Cnt]);
     }
 }
 
 }
 
-void GrPath::ComputeKey(const SkPath& path, const GrStyle& style, GrUniqueKey* key,
+void GrPath::ComputeKey(const SkPath& path, const GrStrokeInfo& stroke, GrUniqueKey* key,
                         bool* outIsVolatile) {
-    if (compute_key_for_line_path(path, style, key)) {
+    if (compute_key_for_line_path(path, stroke, key)) {
         *outIsVolatile = false;
         return;
     }
 
-    if (compute_key_for_oval_path(path, style, key)) {
+    if (compute_key_for_oval_path(path, stroke, key)) {
         *outIsVolatile = false;
         return;
     }
 
-    if (compute_key_for_simple_path(path, style, key)) {
+    if (compute_key_for_simple_path(path, stroke, key)) {
         *outIsVolatile = false;
         return;
     }
 
-    compute_key_for_general_path(path, style, key);
+    compute_key_for_general_path(path, stroke, key);
     *outIsVolatile = path.isVolatile();
 }
 
 #ifdef SK_DEBUG
-bool GrPath::isEqualTo(const SkPath& path, const GrStyle& style) const {
-    // Since this is only called in debug we don't care about performance.
-    int cnt0 = GrStyle::KeySize(fStyle, GrStyle::Apply::kPathEffectAndStrokeRec);
-    int cnt1 = GrStyle::KeySize(style, GrStyle::Apply::kPathEffectAndStrokeRec);
-    if (cnt0 < 0 || cnt1 < 0 || cnt0 != cnt1) {
+bool GrPath::isEqualTo(const SkPath& path, const GrStrokeInfo& stroke) const {
+    if (!fStroke.hasEqualEffect(stroke)) {
         return false;
     }
-    if (cnt0) {
-        SkAutoTArray<uint32_t> key0(cnt0);
-        SkAutoTArray<uint32_t> key1(cnt0);
-        write_style_key(key0.get(), fStyle);
-        write_style_key(key1.get(), style);
-        if (0 != memcmp(key0.get(), key1.get(), cnt0)) {
-            return false;
-        }
-    }
+
     // We treat same-rect ovals as identical - but only when not dashing.
     SkRect ovalBounds;
-    if (!fStyle.isDashed() && fSkPath.isOval(&ovalBounds)) {
+    if (!fStroke.isDashed() && fSkPath.isOval(&ovalBounds)) {
         SkRect otherOvalBounds;
         return path.isOval(&otherOvalBounds) && ovalBounds == otherOvalBounds;
     }