diff options
author | Robert Phillips <robertphillips@google.com> | 2017-09-15 11:48:08 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-09-15 11:48:23 +0000 |
commit | 73fd0d6418844fe8255798708d2af50c31824ad2 (patch) | |
tree | 50a71fc618d33b9f2988f705e9ba8a8095af46fd /src/gpu/GrOpList.cpp | |
parent | 832e31f0e4480e048efb976f8357b07b47dc9c71 (diff) |
Revert "Revert "Pre-allocate some opList dependency list storage""
This reverts commit 1cdbad0e3b0af82cc064764e2a599651729fc8a3.
Reason for revert: It seems unlikely it was this CL
Original change's description:
> Revert "Pre-allocate some opList dependency list storage"
>
> This reverts commit 51066f4dc2c4905e8c6691908025dbef5f85c5b6.
>
> Reason for revert: See if this is causing the TSAN failure
>
> Original change's description:
> > Pre-allocate some opList dependency list storage
> >
> > There is a perf regression (mainly on the Nexus5) for the https://skia-review.googlesource.com/c/skia/+/46200 (Add method to iterate over a GrOp's GrSurfaceProxies)
> >
> > This is another candidate.
> >
> > Change-Id: I276ea44d899166a7d2e74f461f5a6c2c17a21cde
> > Reviewed-on: https://skia-review.googlesource.com/46561
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Robert Phillips <robertphillips@google.com>
>
> TBR=robertphillips@google.com,brianosman@google.com
>
> Change-Id: I83dea2921475e3554943178c9c441fdfb1af1c97
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/46842
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
TBR=robertphillips@google.com,brianosman@google.com
Change-Id: I88caaddc8af321ac545b5d70bcc21cd0158c8614
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/46605
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Diffstat (limited to 'src/gpu/GrOpList.cpp')
-rw-r--r-- | src/gpu/GrOpList.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gpu/GrOpList.cpp b/src/gpu/GrOpList.cpp index 4bc22e4ed9..65d4e73fd0 100644 --- a/src/gpu/GrOpList.cpp +++ b/src/gpu/GrOpList.cpp @@ -81,7 +81,7 @@ void GrOpList::addDependency(GrOpList* dependedOn) { return; // don't add duplicate dependencies } - *fDependencies.push() = dependedOn; + fDependencies.push_back(dependedOn); } // Convert from a GrSurface-based dependency to a GrOpList one |