diff options
author | Hal Canary <halcanary@google.com> | 2018-01-16 18:33:07 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-01-16 18:33:14 +0000 |
commit | be46e24d57537f7ab6854fcd6f6ec07e2c50495c (patch) | |
tree | 8a0304af3a4ea0561af8ecced5b645250f0dd55b /src/gpu/GrOnFlushResourceProvider.cpp | |
parent | 301152cc58e937561dfd6fa93099778fad5b01b3 (diff) |
Revert "Move resourceProvider accessor to GrContextPriv"
This reverts commit 1f9ed8501b0007846b3032f4bfc38aee98c175a1.
Reason for revert:
1. breaking android roll
2. breaking Build-Debian9-Clang-arm-Release-Android_API26
Original change's description:
> Move resourceProvider accessor to GrContextPriv
>
> Change-Id: I5cddd620a7ec4b006b7359864ede58e9d4dd684e
> Reviewed-on: https://skia-review.googlesource.com/94340
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com
Change-Id: I20b2d267c0925f20453b635663654967199a1197
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/94964
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Diffstat (limited to 'src/gpu/GrOnFlushResourceProvider.cpp')
-rw-r--r-- | src/gpu/GrOnFlushResourceProvider.cpp | 26 |
1 files changed, 11 insertions, 15 deletions
diff --git a/src/gpu/GrOnFlushResourceProvider.cpp b/src/gpu/GrOnFlushResourceProvider.cpp index 8de827c5b5..7fcd30f941 100644 --- a/src/gpu/GrOnFlushResourceProvider.cpp +++ b/src/gpu/GrOnFlushResourceProvider.cpp @@ -19,12 +19,10 @@ sk_sp<GrRenderTargetContext> GrOnFlushResourceProvider::makeRenderTargetContext( GrSurfaceDesc tmpDesc = desc; tmpDesc.fFlags |= kRenderTarget_GrSurfaceFlag; - auto proxyProvider = fDrawingMgr->getContext()->contextPriv().proxyProvider(); - auto resourceProvider = fDrawingMgr->getContext()->contextPriv().resourceProvider(); - // Because this is being allocated at the start of a flush we must ensure the proxy // will, when instantiated, have no pending IO. // TODO: fold the kNoPendingIO_Flag into GrSurfaceFlags? + GrProxyProvider* proxyProvider = fDrawingMgr->getContext()->contextPriv().proxyProvider(); sk_sp<GrSurfaceProxy> proxy = proxyProvider->createProxy(tmpDesc, SkBackingFit::kExact, SkBudgeted::kYes, GrResourceProvider::kNoPendingIO_Flag); @@ -44,7 +42,8 @@ sk_sp<GrRenderTargetContext> GrOnFlushResourceProvider::makeRenderTargetContext( // Since this is at flush time and these won't be allocated for us by the GrResourceAllocator // we have to manually ensure it is allocated here. The proxy had best have been created // with the kNoPendingIO flag! - if (!renderTargetContext->asSurfaceProxy()->instantiate(resourceProvider)) { + if (!renderTargetContext->asSurfaceProxy()->instantiate( + fDrawingMgr->getContext()->resourceProvider())) { return nullptr; } @@ -68,12 +67,11 @@ sk_sp<GrRenderTargetContext> GrOnFlushResourceProvider::makeRenderTargetContext( return nullptr; } - auto resourceProvider = fDrawingMgr->getContext()->contextPriv().resourceProvider(); - // Since this is at flush time and these won't be allocated for us by the GrResourceAllocator // we have to manually ensure it is allocated here. The proxy had best have been created // with the kNoPendingIO flag! - if (!renderTargetContext->asSurfaceProxy()->instantiate(resourceProvider)) { + if (!renderTargetContext->asSurfaceProxy()->instantiate( + fDrawingMgr->getContext()->resourceProvider())) { return nullptr; } @@ -84,20 +82,18 @@ sk_sp<GrRenderTargetContext> GrOnFlushResourceProvider::makeRenderTargetContext( sk_sp<GrBuffer> GrOnFlushResourceProvider::makeBuffer(GrBufferType intendedType, size_t size, const void* data) { - auto resourceProvider = fDrawingMgr->getContext()->contextPriv().resourceProvider(); - return sk_sp<GrBuffer>(resourceProvider->createBuffer(size, intendedType, - kDynamic_GrAccessPattern, - GrResourceProvider::kNoPendingIO_Flag, - data)); + GrResourceProvider* rp = fDrawingMgr->getContext()->resourceProvider(); + return sk_sp<GrBuffer>(rp->createBuffer(size, intendedType, kDynamic_GrAccessPattern, + GrResourceProvider::kNoPendingIO_Flag, + data)); } sk_sp<const GrBuffer> GrOnFlushResourceProvider::findOrMakeStaticBuffer(GrBufferType intendedType, size_t size, const void* data, const GrUniqueKey& key) { - auto resourceProvider = fDrawingMgr->getContext()->contextPriv().resourceProvider(); - sk_sp<const GrBuffer> buffer = resourceProvider->findOrMakeStaticBuffer(intendedType, size, - data, key); + GrResourceProvider* rp = fDrawingMgr->getContext()->resourceProvider(); + sk_sp<const GrBuffer> buffer = rp->findOrMakeStaticBuffer(intendedType, size, data, key); // Static buffers should never have pending IO. SkASSERT(!buffer->resourcePriv().hasPendingIO_debugOnly()); return buffer; |