diff options
author | 2015-10-21 04:16:19 -0700 | |
---|---|---|
committer | 2015-10-21 04:16:19 -0700 | |
commit | 81bdbf8bed8b739c2b65ac576e89d0258276e6dc (patch) | |
tree | d013603aa19e350b7faf2d2516c0a2b1857d8e7f /src/gpu/GrDrawTarget.cpp | |
parent | f428df1be3e96d3f8970d0f7f415b862f7da5404 (diff) |
Revert of Dependencies are now added between the drawTargets in GrPipeline (patchset #5 id:100001 of https://codereview.chromium.org/1414903002/ )
Reason for revert:
this may have broken the TSAN and ASAN bots
Original issue's description:
> Dependencies are now added between the drawTargets in GrPipeline
>
> This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting)
>
> BUG=skia:4094
>
> Committed: https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be
TBR=bsalomon@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4094
Review URL: https://codereview.chromium.org/1419613005
Diffstat (limited to 'src/gpu/GrDrawTarget.cpp')
-rw-r--r-- | src/gpu/GrDrawTarget.cpp | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/src/gpu/GrDrawTarget.cpp b/src/gpu/GrDrawTarget.cpp index 8b2267cad6..f42ee111ce 100644 --- a/src/gpu/GrDrawTarget.cpp +++ b/src/gpu/GrDrawTarget.cpp @@ -32,14 +32,13 @@ //////////////////////////////////////////////////////////////////////////////// -GrDrawTarget::GrDrawTarget(GrRenderTarget* rt, GrGpu* gpu, GrResourceProvider* resourceProvider) +GrDrawTarget::GrDrawTarget(GrGpu* gpu, GrResourceProvider* resourceProvider) : fGpu(SkRef(gpu)) , fResourceProvider(resourceProvider) , fFlushState(fGpu, fResourceProvider, 0) , fFlushing(false) , fFirstUnpreparedBatch(0) - , fFlags(0) - , fRenderTarget(rt) { + , fFlags(0) { // TODO: Stop extracting the context (currently needed by GrClipMaskManager) fContext = fGpu->getContext(); fClipMaskManager.reset(new GrClipMaskManager(this)); @@ -51,10 +50,6 @@ GrDrawTarget::GrDrawTarget(GrRenderTarget* rt, GrGpu* gpu, GrResourceProvider* r } GrDrawTarget::~GrDrawTarget() { - if (fRenderTarget && this == fRenderTarget->getLastDrawTarget()) { - fRenderTarget->setLastDrawTarget(nullptr); - } - fGpu->unref(); } @@ -187,7 +182,7 @@ void GrDrawTarget::flush() { // drawTargets will be created to replace them if the SkGpuDevice(s) write to them again. this->makeClosed(); - // Loop over the batches that haven't yet generated their geometry + // Loop over all batches and generate geometry for (; fFirstUnpreparedBatch < fBatches.count(); ++fFirstUnpreparedBatch) { fBatches[fFirstUnpreparedBatch]->prepare(&fFlushState); } @@ -232,10 +227,6 @@ void GrDrawTarget::drawBatch(const GrPipelineBuilder& pipelineBuilder, GrDrawBat return; } -#ifdef ENABLE_MDB - batch->pipeline()->addDependenciesTo(fRenderTarget); -#endif - this->recordBatch(batch); } @@ -467,10 +458,6 @@ void GrDrawTarget::copySurface(GrSurface* dst, const SkIPoint& dstPoint) { GrBatch* batch = GrCopySurfaceBatch::Create(dst, src, srcRect, dstPoint); if (batch) { -#ifdef ENABLE_MDB - this->addDependency(src); -#endif - this->recordBatch(batch); batch->unref(); } |