diff options
author | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-07 19:34:38 +0000 |
---|---|---|
committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-07 19:34:38 +0000 |
commit | e3beb6bd7de7fa211681abbb0be58e80b19885e0 (patch) | |
tree | 0e5a9079910a9f42053b6518f9ba802a258ed46d /src/gpu/GrAllocator.h | |
parent | c4df655b37aea7097d3007b299de582ba517ef16 (diff) |
SkNonCopyable should be used with private inheritance.
This is mostly s/public SkNoncopyable/SkNoncopyable/g.
Two classes (SkDrawLooper::Context and SkPicture::OperationList) don't actually work with SkNoncopyable because they introduce a virtual destructor. I added SkNoncopyableVirtual to make them work as intended. Sort of questionable whether they really need to be noncopyable in the first place, but I guess it doesn't hurt to keep the behavior the same.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/226183018
git-svn-id: http://skia.googlecode.com/svn/trunk@14081 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/gpu/GrAllocator.h')
-rw-r--r-- | src/gpu/GrAllocator.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/gpu/GrAllocator.h b/src/gpu/GrAllocator.h index 4e47fb1607..a2ad408e07 100644 --- a/src/gpu/GrAllocator.h +++ b/src/gpu/GrAllocator.h @@ -13,7 +13,7 @@ #include "SkTArray.h" #include "SkTypes.h" -class GrAllocator : public SkNoncopyable { +class GrAllocator : SkNoncopyable { public: ~GrAllocator() { reset(); @@ -153,7 +153,7 @@ private: }; template <typename T> -class GrTAllocator : public SkNoncopyable { +class GrTAllocator : SkNoncopyable { public: virtual ~GrTAllocator() { this->reset(); }; |