diff options
author | tfarina <tfarina@chromium.org> | 2014-12-14 15:20:10 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-14 15:20:11 -0800 |
commit | 912ed6ebb8e2813e72ed7a3dec3b6710ba7e7405 (patch) | |
tree | a7a10b5d36f9409932ba755f63c7c2de3cad4044 /src/effects | |
parent | 451e822705174c8fe9f5b172c8783d9be3c4c79c (diff) |
Cleanup: Mark some overridden methods with 'SK_OVERRIDE'.
This fixes errors like this:
../../include/gpu/effects/GrPorterDuffXferProcessor.h:27:25: error:
'name' overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
BUG=skia:3075
TEST=ninja -C out/Debug skia_lib
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/804813002
Diffstat (limited to 'src/effects')
-rw-r--r-- | src/effects/SkColorMatrixFilter.cpp | 2 | ||||
-rw-r--r-- | src/effects/SkLightingImageFilter.cpp | 12 | ||||
-rw-r--r-- | src/effects/gradients/SkLinearGradient.cpp | 2 | ||||
-rw-r--r-- | src/effects/gradients/SkTwoPointConicalGradient.h | 2 |
4 files changed, 9 insertions, 9 deletions
diff --git a/src/effects/SkColorMatrixFilter.cpp b/src/effects/SkColorMatrixFilter.cpp index 32f94d9240..2fa9e5d4ed 100644 --- a/src/effects/SkColorMatrixFilter.cpp +++ b/src/effects/SkColorMatrixFilter.cpp @@ -416,7 +416,7 @@ private: this->initClassID<ColorMatrixEffect>(); } - virtual bool onIsEqual(const GrFragmentProcessor& s) const { + virtual bool onIsEqual(const GrFragmentProcessor& s) const SK_OVERRIDE { const ColorMatrixEffect& cme = s.cast<ColorMatrixEffect>(); return cme.fMatrix == fMatrix; } diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp index e53cb02569..8acd7fd97d 100644 --- a/src/effects/SkLightingImageFilter.cpp +++ b/src/effects/SkLightingImageFilter.cpp @@ -590,7 +590,7 @@ public: return fDirection; }; SkPoint3 lightColor(const SkPoint3&) const { return color(); } - virtual LightType type() const { return kDistant_LightType; } + virtual LightType type() const SK_OVERRIDE { return kDistant_LightType; } const SkPoint3& direction() const { return fDirection; } virtual GrGLLight* createGLLight() const SK_OVERRIDE { #if SK_SUPPORT_GPU @@ -620,7 +620,7 @@ protected: SkDistantLight(const SkPoint3& direction, const SkPoint3& color) : INHERITED(color), fDirection(direction) { } - virtual SkLight* transform(const SkMatrix& matrix) const { + virtual SkLight* transform(const SkMatrix& matrix) const SK_OVERRIDE { return new SkDistantLight(direction(), color()); } virtual void onFlattenLight(SkWriteBuffer& buffer) const SK_OVERRIDE { @@ -647,7 +647,7 @@ public: return direction; }; SkPoint3 lightColor(const SkPoint3&) const { return color(); } - virtual LightType type() const { return kPoint_LightType; } + virtual LightType type() const SK_OVERRIDE { return kPoint_LightType; } const SkPoint3& location() const { return fLocation; } virtual GrGLLight* createGLLight() const SK_OVERRIDE { #if SK_SUPPORT_GPU @@ -666,7 +666,7 @@ public: return INHERITED::isEqual(other) && fLocation == o.fLocation; } - virtual SkLight* transform(const SkMatrix& matrix) const { + virtual SkLight* transform(const SkMatrix& matrix) const SK_OVERRIDE { SkPoint location2 = SkPoint::Make(fLocation.fX, fLocation.fY); matrix.mapPoints(&location2, 1); // Use X scale and Y scale on Z and average the result @@ -710,7 +710,7 @@ public: fConeScale = SkScalarInvert(antiAliasThreshold); } - virtual SkLight* transform(const SkMatrix& matrix) const { + virtual SkLight* transform(const SkMatrix& matrix) const SK_OVERRIDE { SkPoint location2 = SkPoint::Make(fLocation.fX, fLocation.fY); matrix.mapPoints(&location2, 1); // Use X scale and Y scale on Z and average the result @@ -755,7 +755,7 @@ public: #endif } virtual bool requiresFragmentPosition() const SK_OVERRIDE { return true; } - virtual LightType type() const { return kSpot_LightType; } + virtual LightType type() const SK_OVERRIDE { return kSpot_LightType; } const SkPoint3& location() const { return fLocation; } const SkPoint3& target() const { return fTarget; } SkScalar specularExponent() const { return fSpecularExponent; } diff --git a/src/effects/gradients/SkLinearGradient.cpp b/src/effects/gradients/SkLinearGradient.cpp index 6bd5d83e32..1da8c7a311 100644 --- a/src/effects/gradients/SkLinearGradient.cpp +++ b/src/effects/gradients/SkLinearGradient.cpp @@ -493,7 +493,7 @@ public: virtual ~GrLinearGradient() { } - virtual const char* name() const { return "Linear Gradient"; } + virtual const char* name() const SK_OVERRIDE { return "Linear Gradient"; } virtual void getGLProcessorKey(const GrGLCaps& caps, GrProcessorKeyBuilder* b) const SK_OVERRIDE { diff --git a/src/effects/gradients/SkTwoPointConicalGradient.h b/src/effects/gradients/SkTwoPointConicalGradient.h index 941d12bc5a..3537791e54 100644 --- a/src/effects/gradients/SkTwoPointConicalGradient.h +++ b/src/effects/gradients/SkTwoPointConicalGradient.h @@ -60,7 +60,7 @@ public: virtual BitmapType asABitmap(SkBitmap* bitmap, SkMatrix* matrix, - TileMode* xy) const; + TileMode* xy) const SK_OVERRIDE; virtual SkShader::GradientType asAGradient(GradientInfo* info) const SK_OVERRIDE; virtual bool asFragmentProcessor(GrContext*, const SkPaint&, const SkMatrix*, GrColor*, GrFragmentProcessor**) const SK_OVERRIDE; |