diff options
author | reed <reed@google.com> | 2016-04-03 09:11:13 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-04-03 09:11:13 -0700 |
commit | 60c9b58b3214b0154c931656e91e39b230e987d8 (patch) | |
tree | 6dd59cf90dd96a443a50ae4b6fa14be6f778c823 /src/effects | |
parent | cf9bafceafaf6c0bf8b0eac8de509aa1d8407fca (diff) |
change flattenable factory to return sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855733002
Review URL: https://codereview.chromium.org/1855733002
Diffstat (limited to 'src/effects')
41 files changed, 101 insertions, 95 deletions
diff --git a/src/effects/Sk1DPathEffect.cpp b/src/effects/Sk1DPathEffect.cpp index 0d61632175..26cd046aa8 100644 --- a/src/effects/Sk1DPathEffect.cpp +++ b/src/effects/Sk1DPathEffect.cpp @@ -145,14 +145,14 @@ SkScalar SkPath1DPathEffect::begin(SkScalar contourLength) const { return fInitialOffset; } -SkFlattenable* SkPath1DPathEffect::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkPath1DPathEffect::CreateProc(SkReadBuffer& buffer) { SkScalar advance = buffer.readScalar(); if (advance > 0) { SkPath path; buffer.readPath(&path); SkScalar phase = buffer.readScalar(); Style style = (Style)buffer.readUInt(); - return SkPath1DPathEffect::Make(path, advance, phase, style).release(); + return SkPath1DPathEffect::Make(path, advance, phase, style); } return nullptr; } diff --git a/src/effects/Sk2DPathEffect.cpp b/src/effects/Sk2DPathEffect.cpp index da43d22487..52e3fa5e1c 100644 --- a/src/effects/Sk2DPathEffect.cpp +++ b/src/effects/Sk2DPathEffect.cpp @@ -106,11 +106,11 @@ void SkLine2DPathEffect::nextSpan(int u, int v, int ucount, SkPath* dst) const { } } -SkFlattenable* SkLine2DPathEffect::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkLine2DPathEffect::CreateProc(SkReadBuffer& buffer) { SkMatrix matrix; buffer.readMatrix(&matrix); SkScalar width = buffer.readScalar(); - return SkLine2DPathEffect::Make(width, matrix).release(); + return SkLine2DPathEffect::Make(width, matrix); } void SkLine2DPathEffect::flatten(SkWriteBuffer &buffer) const { @@ -134,12 +134,12 @@ SkPath2DPathEffect::SkPath2DPathEffect(const SkMatrix& m, const SkPath& p) : INHERITED(m), fPath(p) { } -SkFlattenable* SkPath2DPathEffect::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkPath2DPathEffect::CreateProc(SkReadBuffer& buffer) { SkMatrix matrix; buffer.readMatrix(&matrix); SkPath path; buffer.readPath(&path); - return SkPath2DPathEffect::Make(matrix, path).release(); + return SkPath2DPathEffect::Make(matrix, path); } void SkPath2DPathEffect::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkAlphaThresholdFilter.cpp b/src/effects/SkAlphaThresholdFilter.cpp index 1c79c45194..5a9ad79a9d 100644 --- a/src/effects/SkAlphaThresholdFilter.cpp +++ b/src/effects/SkAlphaThresholdFilter.cpp @@ -265,13 +265,13 @@ void AlphaThresholdEffect::onComputeInvariantOutput(GrInvariantOutput* inout) co #endif -SkFlattenable* SkAlphaThresholdFilterImpl::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkAlphaThresholdFilterImpl::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); SkScalar inner = buffer.readScalar(); SkScalar outer = buffer.readScalar(); SkRegion rgn; buffer.readRegion(&rgn); - return SkAlphaThresholdFilter::Make(rgn, inner, outer, common.getInput(0)).release(); + return SkAlphaThresholdFilter::Make(rgn, inner, outer, common.getInput(0)); } SkAlphaThresholdFilterImpl::SkAlphaThresholdFilterImpl(const SkRegion& region, diff --git a/src/effects/SkArcToPathEffect.cpp b/src/effects/SkArcToPathEffect.cpp index c660de9db4..a6273db092 100644 --- a/src/effects/SkArcToPathEffect.cpp +++ b/src/effects/SkArcToPathEffect.cpp @@ -61,8 +61,8 @@ DONE: return true; } -SkFlattenable* SkArcToPathEffect::CreateProc(SkReadBuffer& buffer) { - return SkArcToPathEffect::Make(buffer.readScalar()).release(); +sk_sp<SkFlattenable> SkArcToPathEffect::CreateProc(SkReadBuffer& buffer) { + return SkArcToPathEffect::Make(buffer.readScalar()); } void SkArcToPathEffect::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkArithmeticMode.cpp b/src/effects/SkArithmeticMode.cpp index b225e6d4c1..fbe6358ae4 100644 --- a/src/effects/SkArithmeticMode.cpp +++ b/src/effects/SkArithmeticMode.cpp @@ -54,13 +54,13 @@ private: typedef SkXfermode INHERITED; }; -SkFlattenable* SkArithmeticMode_scalar::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkArithmeticMode_scalar::CreateProc(SkReadBuffer& buffer) { const SkScalar k1 = buffer.readScalar(); const SkScalar k2 = buffer.readScalar(); const SkScalar k3 = buffer.readScalar(); const SkScalar k4 = buffer.readScalar(); const bool enforcePMColor = buffer.readBool(); - return SkArithmeticMode::Make(k1, k2, k3, k4, enforcePMColor).release(); + return SkArithmeticMode::Make(k1, k2, k3, k4, enforcePMColor); } static int pinToByte(int value) { diff --git a/src/effects/SkAvoidXfermode.cpp b/src/effects/SkAvoidXfermode.cpp index 4b7e63667a..58051288ee 100644 --- a/src/effects/SkAvoidXfermode.cpp +++ b/src/effects/SkAvoidXfermode.cpp @@ -21,11 +21,11 @@ SkAvoidXfermode::SkAvoidXfermode(SkColor opColor, U8CPU tolerance, Mode mode) { fMode = mode; } -SkFlattenable* SkAvoidXfermode::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkAvoidXfermode::CreateProc(SkReadBuffer& buffer) { const SkColor color = buffer.readColor(); const unsigned tolerance = buffer.readUInt(); const unsigned mode = buffer.readUInt(); - return Make(color, tolerance, (Mode)mode).release(); + return Make(color, tolerance, (Mode)mode); } void SkAvoidXfermode::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkBlurDrawLooper.cpp b/src/effects/SkBlurDrawLooper.cpp index c8e20e1265..2578d092bb 100644 --- a/src/effects/SkBlurDrawLooper.cpp +++ b/src/effects/SkBlurDrawLooper.cpp @@ -61,13 +61,13 @@ void SkBlurDrawLooper::init(SkScalar sigma, SkScalar dx, SkScalar dy, this->initEffects(); } -SkFlattenable* SkBlurDrawLooper::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkBlurDrawLooper::CreateProc(SkReadBuffer& buffer) { const SkColor color = buffer.readColor(); const SkScalar sigma = buffer.readScalar(); const SkScalar dx = buffer.readScalar(); const SkScalar dy = buffer.readScalar(); const uint32_t flags = buffer.read32(); - return Make(color, sigma, dx, dy, flags).release(); + return Make(color, sigma, dx, dy, flags); } void SkBlurDrawLooper::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkBlurImageFilter.cpp b/src/effects/SkBlurImageFilter.cpp index c7964c3218..e7b326b7a9 100644 --- a/src/effects/SkBlurImageFilter.cpp +++ b/src/effects/SkBlurImageFilter.cpp @@ -42,11 +42,12 @@ SkBlurImageFilter::SkBlurImageFilter(SkScalar sigmaX, : INHERITED(1, &input, cropRect), fSigma(SkSize::Make(sigmaX, sigmaY)) { } -SkFlattenable* SkBlurImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkBlurImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); SkScalar sigmaX = buffer.readScalar(); SkScalar sigmaY = buffer.readScalar(); - return Create(sigmaX, sigmaY, common.getInput(0).get(), &common.cropRect()); + return sk_sp<SkFlattenable>(Create(sigmaX, sigmaY, common.getInput(0).get(), + &common.cropRect())); } void SkBlurImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkBlurMaskFilter.cpp b/src/effects/SkBlurMaskFilter.cpp index 517aa3a88d..ec4fd939fa 100644 --- a/src/effects/SkBlurMaskFilter.cpp +++ b/src/effects/SkBlurMaskFilter.cpp @@ -581,12 +581,12 @@ void SkBlurMaskFilterImpl::computeFastBounds(const SkRect& src, src.fRight + pad, src.fBottom + pad); } -SkFlattenable* SkBlurMaskFilterImpl::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkBlurMaskFilterImpl::CreateProc(SkReadBuffer& buffer) { const SkScalar sigma = buffer.readScalar(); const unsigned style = buffer.readUInt(); const unsigned flags = buffer.readUInt(); if (style <= kLastEnum_SkBlurStyle) { - return SkBlurMaskFilter::Create((SkBlurStyle)style, sigma, flags); + return sk_sp<SkFlattenable>(SkBlurMaskFilter::Create((SkBlurStyle)style, sigma, flags)); } return nullptr; } diff --git a/src/effects/SkColorCubeFilter.cpp b/src/effects/SkColorCubeFilter.cpp index d80a02fef2..23241c0255 100644 --- a/src/effects/SkColorCubeFilter.cpp +++ b/src/effects/SkColorCubeFilter.cpp @@ -136,13 +136,13 @@ void SkColorCubeFilter::filterSpan(const SkPMColor src[], int count, SkPMColor d (const SkColor*)fCubeData->data()); } -SkFlattenable* SkColorCubeFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkColorCubeFilter::CreateProc(SkReadBuffer& buffer) { int cubeDimension = buffer.readInt(); auto cubeData(buffer.readByteArrayAsData()); if (!buffer.validate(is_valid_3D_lut(cubeData.get(), cubeDimension))) { return nullptr; } - return Make(std::move(cubeData), cubeDimension).release(); + return Make(std::move(cubeData), cubeDimension); } void SkColorCubeFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkColorFilterImageFilter.cpp b/src/effects/SkColorFilterImageFilter.cpp index a5904ea60b..c1637d8128 100644 --- a/src/effects/SkColorFilterImageFilter.cpp +++ b/src/effects/SkColorFilterImageFilter.cpp @@ -41,10 +41,10 @@ SkColorFilterImageFilter::SkColorFilterImageFilter(SkColorFilter* cf, , fColorFilter(SkRef(cf)) { } -SkFlattenable* SkColorFilterImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkColorFilterImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); sk_sp<SkColorFilter> cf(buffer.readColorFilter()); - return Create(cf.get(), common.getInput(0).get(), &common.cropRect()); + return sk_sp<SkFlattenable>(Create(cf.get(), common.getInput(0).get(), &common.cropRect())); } void SkColorFilterImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkComposeImageFilter.cpp b/src/effects/SkComposeImageFilter.cpp index e2a27a8312..e960f966c5 100644 --- a/src/effects/SkComposeImageFilter.cpp +++ b/src/effects/SkComposeImageFilter.cpp @@ -58,9 +58,9 @@ SkIRect SkComposeImageFilter::onFilterBounds(const SkIRect& src, const SkMatrix& return outer->filterBounds(inner->filterBounds(src, ctm, direction), ctm, direction); } -SkFlattenable* SkComposeImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkComposeImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 2); - return SkComposeImageFilter::Make(common.getInput(0), common.getInput(1)).release(); + return SkComposeImageFilter::Make(common.getInput(0), common.getInput(1)); } #ifndef SK_IGNORE_TO_STRING diff --git a/src/effects/SkCornerPathEffect.cpp b/src/effects/SkCornerPathEffect.cpp index c38889c608..909ef31478 100644 --- a/src/effects/SkCornerPathEffect.cpp +++ b/src/effects/SkCornerPathEffect.cpp @@ -138,8 +138,8 @@ DONE: return true; } -SkFlattenable* SkCornerPathEffect::CreateProc(SkReadBuffer& buffer) { - return SkCornerPathEffect::Make(buffer.readScalar()).release(); +sk_sp<SkFlattenable> SkCornerPathEffect::CreateProc(SkReadBuffer& buffer) { + return SkCornerPathEffect::Make(buffer.readScalar()); } void SkCornerPathEffect::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkDashPathEffect.cpp b/src/effects/SkDashPathEffect.cpp index 51bf54839c..90af32ec5b 100644 --- a/src/effects/SkDashPathEffect.cpp +++ b/src/effects/SkDashPathEffect.cpp @@ -360,12 +360,12 @@ void SkDashPathEffect::flatten(SkWriteBuffer& buffer) const { buffer.writeScalarArray(fIntervals, fCount); } -SkFlattenable* SkDashPathEffect::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkDashPathEffect::CreateProc(SkReadBuffer& buffer) { const SkScalar phase = buffer.readScalar(); uint32_t count = buffer.getArrayCount(); SkAutoSTArray<32, SkScalar> intervals(count); if (buffer.readScalarArray(intervals.get(), count)) { - return Make(intervals.get(), SkToInt(count), phase).release(); + return Make(intervals.get(), SkToInt(count), phase); } return nullptr; } diff --git a/src/effects/SkDiscretePathEffect.cpp b/src/effects/SkDiscretePathEffect.cpp index 1c6039c842..5d5fc6528c 100644 --- a/src/effects/SkDiscretePathEffect.cpp +++ b/src/effects/SkDiscretePathEffect.cpp @@ -127,11 +127,11 @@ bool SkDiscretePathEffect::filterPath(SkPath* dst, const SkPath& src, return true; } -SkFlattenable* SkDiscretePathEffect::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkDiscretePathEffect::CreateProc(SkReadBuffer& buffer) { SkScalar segLength = buffer.readScalar(); SkScalar perterb = buffer.readScalar(); uint32_t seed = buffer.readUInt(); - return Make(segLength, perterb, seed).release(); + return Make(segLength, perterb, seed); } void SkDiscretePathEffect::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkDisplacementMapEffect.cpp b/src/effects/SkDisplacementMapEffect.cpp index d054e58e51..447a20bcb2 100644 --- a/src/effects/SkDisplacementMapEffect.cpp +++ b/src/effects/SkDisplacementMapEffect.cpp @@ -195,13 +195,13 @@ SkDisplacementMapEffect::SkDisplacementMapEffect(ChannelSelectorType xChannelSel SkDisplacementMapEffect::~SkDisplacementMapEffect() { } -SkFlattenable* SkDisplacementMapEffect::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkDisplacementMapEffect::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 2); ChannelSelectorType xsel = (ChannelSelectorType)buffer.readInt(); ChannelSelectorType ysel = (ChannelSelectorType)buffer.readInt(); SkScalar scale = buffer.readScalar(); - return Create(xsel, ysel, scale, - common.getInput(0).get(), common.getInput(1).get(), &common.cropRect()); + return sk_sp<SkFlattenable>(Create(xsel, ysel, scale, common.getInput(0).get(), + common.getInput(1).get(), &common.cropRect())); } void SkDisplacementMapEffect::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkDropShadowImageFilter.cpp b/src/effects/SkDropShadowImageFilter.cpp index 6e750ca74c..331cfbd68b 100644 --- a/src/effects/SkDropShadowImageFilter.cpp +++ b/src/effects/SkDropShadowImageFilter.cpp @@ -27,7 +27,7 @@ SkDropShadowImageFilter::SkDropShadowImageFilter(SkScalar dx, SkScalar dy, , fShadowMode(shadowMode) { } -SkFlattenable* SkDropShadowImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkDropShadowImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); SkScalar dx = buffer.readScalar(); SkScalar dy = buffer.readScalar(); @@ -37,8 +37,8 @@ SkFlattenable* SkDropShadowImageFilter::CreateProc(SkReadBuffer& buffer) { ShadowMode shadowMode = buffer.isVersionLT(SkReadBuffer::kDropShadowMode_Version) ? kDrawShadowAndForeground_ShadowMode : static_cast<ShadowMode>(buffer.readInt()); - return Create(dx, dy, sigmaX, sigmaY, color, shadowMode, common.getInput(0).get(), - &common.cropRect()); + return sk_sp<SkFlattenable>(Create(dx, dy, sigmaX, sigmaY, color, shadowMode, + common.getInput(0).get(), &common.cropRect())); } void SkDropShadowImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkEmbossMaskFilter.cpp b/src/effects/SkEmbossMaskFilter.cpp index aacc191ff7..aa93e5a594 100644 --- a/src/effects/SkEmbossMaskFilter.cpp +++ b/src/effects/SkEmbossMaskFilter.cpp @@ -112,12 +112,12 @@ bool SkEmbossMaskFilter::filterMask(SkMask* dst, const SkMask& src, return true; } -SkFlattenable* SkEmbossMaskFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkEmbossMaskFilter::CreateProc(SkReadBuffer& buffer) { Light light; if (buffer.readByteArray(&light, sizeof(Light))) { light.fPad = 0; // for the font-cache lookup to be clean const SkScalar sigma = buffer.readScalar(); - return Create(sigma, light); + return sk_sp<SkFlattenable>(Create(sigma, light)); } return nullptr; } diff --git a/src/effects/SkImageSource.cpp b/src/effects/SkImageSource.cpp index f16e5a140f..cf8cae2c39 100644 --- a/src/effects/SkImageSource.cpp +++ b/src/effects/SkImageSource.cpp @@ -35,7 +35,7 @@ SkImageSource::SkImageSource(sk_sp<SkImage> image, , fFilterQuality(filterQuality) { } -SkFlattenable* SkImageSource::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkImageSource::CreateProc(SkReadBuffer& buffer) { SkFilterQuality filterQuality = (SkFilterQuality)buffer.readInt(); SkRect src, dst; @@ -47,7 +47,7 @@ SkFlattenable* SkImageSource::CreateProc(SkReadBuffer& buffer) { return nullptr; } - return SkImageSource::Make(std::move(image), src, dst, filterQuality).release(); + return SkImageSource::Make(std::move(image), src, dst, filterQuality); } void SkImageSource::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkLayerDrawLooper.cpp b/src/effects/SkLayerDrawLooper.cpp index b3430bb1e4..ffcaa43e20 100644 --- a/src/effects/SkLayerDrawLooper.cpp +++ b/src/effects/SkLayerDrawLooper.cpp @@ -214,7 +214,7 @@ void SkLayerDrawLooper::flatten(SkWriteBuffer& buffer) const { } } -SkFlattenable* SkLayerDrawLooper::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkLayerDrawLooper::CreateProc(SkReadBuffer& buffer) { int count = buffer.readInt(); Builder builder; @@ -229,7 +229,7 @@ SkFlattenable* SkLayerDrawLooper::CreateProc(SkReadBuffer& buffer) { info.fPostTranslate = buffer.readBool(); buffer.readPaint(builder.addLayerOnTop(info)); } - return builder.detach().release(); + return builder.detach(); } #ifndef SK_IGNORE_TO_STRING diff --git a/src/effects/SkLayerRasterizer.cpp b/src/effects/SkLayerRasterizer.cpp index a51613a162..91502b7e84 100644 --- a/src/effects/SkLayerRasterizer.cpp +++ b/src/effects/SkLayerRasterizer.cpp @@ -144,8 +144,8 @@ bool SkLayerRasterizer::onRasterize(const SkPath& path, const SkMatrix& matrix, return true; } -SkFlattenable* SkLayerRasterizer::CreateProc(SkReadBuffer& buffer) { - return new SkLayerRasterizer(ReadLayers(buffer)); +sk_sp<SkFlattenable> SkLayerRasterizer::CreateProc(SkReadBuffer& buffer) { + return sk_sp<SkFlattenable>(new SkLayerRasterizer(ReadLayers(buffer))); } SkDeque* SkLayerRasterizer::ReadLayers(SkReadBuffer& buffer) { diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp index 55a1f22909..c27a55476f 100644 --- a/src/effects/SkLightingImageFilter.cpp +++ b/src/effects/SkLightingImageFilter.cpp @@ -1210,12 +1210,13 @@ SkDiffuseLightingImageFilter::SkDiffuseLightingImageFilter(SkImageFilterLight* l { } -SkFlattenable* SkDiffuseLightingImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkDiffuseLightingImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); SkAutoTUnref<SkImageFilterLight> light(SkImageFilterLight::UnflattenLight(buffer)); SkScalar surfaceScale = buffer.readScalar(); SkScalar kd = buffer.readScalar(); - return Create(light, surfaceScale, kd, common.getInput(0).get(), &common.cropRect()); + return sk_sp<SkFlattenable>(Create(light, surfaceScale, kd, common.getInput(0).get(), + &common.cropRect())); } void SkDiffuseLightingImageFilter::flatten(SkWriteBuffer& buffer) const { @@ -1352,13 +1353,14 @@ SkSpecularLightingImageFilter::SkSpecularLightingImageFilter(SkImageFilterLight* { } -SkFlattenable* SkSpecularLightingImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkSpecularLightingImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); SkAutoTUnref<SkImageFilterLight> light(SkImageFilterLight::UnflattenLight(buffer)); SkScalar surfaceScale = buffer.readScalar(); SkScalar ks = buffer.readScalar(); SkScalar shine = buffer.readScalar(); - return Create(light, surfaceScale, ks, shine, common.getInput(0).get(), &common.cropRect()); + return sk_sp<SkFlattenable>(Create(light, surfaceScale, ks, shine, common.getInput(0).get(), + &common.cropRect())); } void SkSpecularLightingImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkLumaColorFilter.cpp b/src/effects/SkLumaColorFilter.cpp index 18b2485a30..28b2e1eb44 100644 --- a/src/effects/SkLumaColorFilter.cpp +++ b/src/effects/SkLumaColorFilter.cpp @@ -43,7 +43,9 @@ sk_sp<SkColorFilter> SkLumaColorFilter::Make() { SkLumaColorFilter::SkLumaColorFilter() : INHERITED() {} -SkFlattenable* SkLumaColorFilter::CreateProc(SkReadBuffer&) { return new SkLumaColorFilter; } +sk_sp<SkFlattenable> SkLumaColorFilter::CreateProc(SkReadBuffer&) { + return Make(); +} void SkLumaColorFilter::flatten(SkWriteBuffer&) const {} diff --git a/src/effects/SkMagnifierImageFilter.cpp b/src/effects/SkMagnifierImageFilter.cpp index bfad549485..dfd7f04f6a 100644 --- a/src/effects/SkMagnifierImageFilter.cpp +++ b/src/effects/SkMagnifierImageFilter.cpp @@ -281,11 +281,11 @@ bool SkMagnifierImageFilter::asFragmentProcessor(GrFragmentProcessor** fp, } #endif -SkFlattenable* SkMagnifierImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkMagnifierImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); SkRect src; buffer.readRect(&src); - return Create(src, buffer.readScalar(), common.getInput(0).get()); + return sk_sp<SkFlattenable>(Create(src, buffer.readScalar(), common.getInput(0).get())); } void SkMagnifierImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkMatrixConvolutionImageFilter.cpp b/src/effects/SkMatrixConvolutionImageFilter.cpp index 2a32fd5cdc..accebb5a4f 100644 --- a/src/effects/SkMatrixConvolutionImageFilter.cpp +++ b/src/effects/SkMatrixConvolutionImageFilter.cpp @@ -74,7 +74,7 @@ SkImageFilter* SkMatrixConvolutionImageFilter::Create( tileMode, convolveAlpha, input, cropRect); } -SkFlattenable* SkMatrixConvolutionImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkMatrixConvolutionImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); SkISize kernelSize; kernelSize.fWidth = buffer.readInt(); @@ -96,8 +96,8 @@ SkFlattenable* SkMatrixConvolutionImageFilter::CreateProc(SkReadBuffer& buffer) kernelOffset.fY = buffer.readInt(); TileMode tileMode = (TileMode)buffer.readInt(); bool convolveAlpha = buffer.readBool(); - return Create(kernelSize, kernel.get(), gain, bias, kernelOffset, tileMode, convolveAlpha, - common.getInput(0).get(), &common.cropRect()); + return sk_sp<SkFlattenable>(Create(kernelSize, kernel.get(), gain, bias, kernelOffset, tileMode, + convolveAlpha, common.getInput(0).get(), &common.cropRect())); } void SkMatrixConvolutionImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkMergeImageFilter.cpp b/src/effects/SkMergeImageFilter.cpp index cd16d43db3..44e6caf087 100755 --- a/src/effects/SkMergeImageFilter.cpp +++ b/src/effects/SkMergeImageFilter.cpp @@ -131,7 +131,7 @@ sk_sp<SkSpecialImage> SkMergeImageFilter::onFilterImage(SkSpecialImage* source, return surf->makeImageSnapshot(); } -SkFlattenable* SkMergeImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkMergeImageFilter::CreateProc(SkReadBuffer& buffer) { Common common; if (!common.unflatten(buffer, -1)) { return nullptr; @@ -152,9 +152,9 @@ SkFlattenable* SkMergeImageFilter::CreateProc(SkReadBuffer& buffer) { if (!buffer.isValid()) { return nullptr; } - return Make(common.inputs(), count, modes.get(), &common.cropRect()).release(); + return Make(common.inputs(), count, modes.get(), &common.cropRect()); } - return Make(common.inputs(), count, nullptr, &common.cropRect()).release(); + return Make(common.inputs(), count, nullptr, &common.cropRect()); } void SkMergeImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkMorphologyImageFilter.cpp b/src/effects/SkMorphologyImageFilter.cpp index dbb116ed22..bf8811b887 100644 --- a/src/effects/SkMorphologyImageFilter.cpp +++ b/src/effects/SkMorphologyImageFilter.cpp @@ -72,18 +72,20 @@ SkIRect SkMorphologyImageFilter::onFilterNodeBounds(const SkIRect& src, const Sk return src.makeOutset(SkScalarCeilToInt(radius.x()), SkScalarCeilToInt(radius.y())); } -SkFlattenable* SkErodeImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkErodeImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); const int width = buffer.readInt(); const int height = buffer.readInt(); - return Create(width, height, common.getInput(0).get(), &common.cropRect()); + return sk_sp<SkFlattenable>(Create(width, height, common.getInput(0).get(), + &common.cropRect())); } -SkFlattenable* SkDilateImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkDilateImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); const int width = buffer.readInt(); const int height = buffer.readInt(); - return Create(width, height, common.getInput(0).get(), &common.cropRect()); + return sk_sp<SkFlattenable>(Create(width, height, common.getInput(0).get(), + &common.cropRect())); } #ifndef SK_IGNORE_TO_STRING diff --git a/src/effects/SkOffsetImageFilter.cpp b/src/effects/SkOffsetImageFilter.cpp index 69f1895402..1df47d8b6f 100644 --- a/src/effects/SkOffsetImageFilter.cpp +++ b/src/effects/SkOffsetImageFilter.cpp @@ -82,11 +82,11 @@ SkIRect SkOffsetImageFilter::onFilterNodeBounds(const SkIRect& src, const SkMatr return src.makeOffset(SkScalarCeilToInt(vec.fX), SkScalarCeilToInt(vec.fY)); } -SkFlattenable* SkOffsetImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkOffsetImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); SkPoint offset; buffer.readPoint(&offset); - return Make(offset.x(), offset.y(), common.getInput(0), &common.cropRect()).release(); + return Make(offset.x(), offset.y(), common.getInput(0), &common.cropRect()); } void SkOffsetImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkPaintImageFilter.cpp b/src/effects/SkPaintImageFilter.cpp index 4462b757f5..f561928684 100644 --- a/src/effects/SkPaintImageFilter.cpp +++ b/src/effects/SkPaintImageFilter.cpp @@ -17,11 +17,11 @@ SkPaintImageFilter::SkPaintImageFilter(const SkPaint& paint, const CropRect* cro , fPaint(paint) { } -SkFlattenable* SkPaintImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkPaintImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 0); SkPaint paint; buffer.readPaint(&paint); - return SkPaintImageFilter::Make(paint, &common.cropRect()).release(); + return SkPaintImageFilter::Make(paint, &common.cropRect()); } void SkPaintImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkPerlinNoiseShader.cpp b/src/effects/SkPerlinNoiseShader.cpp index 72b7e0280d..c8b04c9975 100644 --- a/src/effects/SkPerlinNoiseShader.cpp +++ b/src/effects/SkPerlinNoiseShader.cpp @@ -286,7 +286,7 @@ SkPerlinNoiseShader::SkPerlinNoiseShader(SkPerlinNoiseShader::Type type, SkPerlinNoiseShader::~SkPerlinNoiseShader() { } -SkFlattenable* SkPerlinNoiseShader::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkPerlinNoiseShader::CreateProc(SkReadBuffer& buffer) { Type type = (Type)buffer.readInt(); SkScalar freqX = buffer.readScalar(); SkScalar freqY = buffer.readScalar(); @@ -299,10 +299,10 @@ SkFlattenable* SkPerlinNoiseShader::CreateProc(SkReadBuffer& buffer) { switch (type) { case kFractalNoise_Type: return SkPerlinNoiseShader::MakeFractalNoise(freqX, freqY, octaves, seed, - &tileSize).release(); + &tileSize); case kTurbulence_Type: return SkPerlinNoiseShader::MakeTurbulence(freqX, freqY, octaves, seed, - &tileSize).release(); + &tileSize); default: return nullptr; } diff --git a/src/effects/SkPictureImageFilter.cpp b/src/effects/SkPictureImageFilter.cpp index 2005463bd4..2dff41a8d7 100644 --- a/src/effects/SkPictureImageFilter.cpp +++ b/src/effects/SkPictureImageFilter.cpp @@ -31,7 +31,7 @@ SkPictureImageFilter::SkPictureImageFilter(sk_sp<SkPicture> picture, const SkRec , fFilterQuality(filterQuality) { } -SkFlattenable* SkPictureImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkPictureImageFilter::CreateProc(SkReadBuffer& buffer) { sk_sp<SkPicture> picture; SkRect cropRect; @@ -58,9 +58,9 @@ SkFlattenable* SkPictureImageFilter::CreateProc(SkReadBuffer& buffer) { } else { filterQuality = (SkFilterQuality)buffer.readInt(); } - return MakeForLocalSpace(picture, cropRect, filterQuality).release(); + return MakeForLocalSpace(picture, cropRect, filterQuality); } - return Make(picture, cropRect).release(); + return Make(picture, cropRect); } void SkPictureImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkPixelXorXfermode.cpp b/src/effects/SkPixelXorXfermode.cpp index 4ad3f1bd76..d8861e6df1 100644 --- a/src/effects/SkPixelXorXfermode.cpp +++ b/src/effects/SkPixelXorXfermode.cpp @@ -26,8 +26,8 @@ void SkPixelXorXfermode::flatten(SkWriteBuffer& wb) const { SkGetPackedB32(fOpColor))); } -SkFlattenable* SkPixelXorXfermode::CreateProc(SkReadBuffer& buffer) { - return Make(buffer.readColor()).release(); +sk_sp<SkFlattenable> SkPixelXorXfermode::CreateProc(SkReadBuffer& buffer) { + return Make(buffer.readColor()); } #ifndef SK_IGNORE_TO_STRING diff --git a/src/effects/SkTableColorFilter.cpp b/src/effects/SkTableColorFilter.cpp index 4ce0b4bb0e..10b71f86c6 100644 --- a/src/effects/SkTableColorFilter.cpp +++ b/src/effects/SkTableColorFilter.cpp @@ -207,7 +207,7 @@ void SkTable_ColorFilter::flatten(SkWriteBuffer& buffer) const { buffer.writeByteArray(storage, size); } -SkFlattenable* SkTable_ColorFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkTable_ColorFilter::CreateProc(SkReadBuffer& buffer) { const int flags = buffer.read32(); const size_t count = gCountNibBits[flags & 0xF]; SkASSERT(count <= 4); @@ -251,7 +251,7 @@ SkFlattenable* SkTable_ColorFilter::CreateProc(SkReadBuffer& buffer) { b = ptr; ptr += 256; } - return SkTableColorFilter::MakeARGB(a, r, g, b).release(); + return SkTableColorFilter::MakeARGB(a, r, g, b); } bool SkTable_ColorFilter::asComponentTable(SkBitmap* table) const { diff --git a/src/effects/SkTableMaskFilter.cpp b/src/effects/SkTableMaskFilter.cpp index ddf9f33f54..d834652962 100644 --- a/src/effects/SkTableMaskFilter.cpp +++ b/src/effects/SkTableMaskFilter.cpp @@ -73,12 +73,12 @@ void SkTableMaskFilter::flatten(SkWriteBuffer& wb) const { wb.writeByteArray(fTable, 256); } -SkFlattenable* SkTableMaskFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkTableMaskFilter::CreateProc(SkReadBuffer& buffer) { uint8_t table[256]; if (!buffer.readByteArray(table, 256)) { return nullptr; } - return Create(table); + return sk_sp<SkFlattenable>(Create(table)); } /////////////////////////////////////////////////////////////////////////////// diff --git a/src/effects/SkTestImageFilters.cpp b/src/effects/SkTestImageFilters.cpp index a77f5190ff..e9ec7c19ce 100755 --- a/src/effects/SkTestImageFilters.cpp +++ b/src/effects/SkTestImageFilters.cpp @@ -75,9 +75,9 @@ bool SkDownSampleImageFilter::onFilterImageDeprecated(Proxy* proxy, const SkBitm return true; } -SkFlattenable* SkDownSampleImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkDownSampleImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); - return Create(buffer.readScalar(), common.getInput(0).get()); + return sk_sp<SkFlattenable>(Create(buffer.readScalar(), common.getInput(0).get())); } void SkDownSampleImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkTileImageFilter.cpp b/src/effects/SkTileImageFilter.cpp index 8f556ff4d0..0ff19b23ad 100644 --- a/src/effects/SkTileImageFilter.cpp +++ b/src/effects/SkTileImageFilter.cpp @@ -123,12 +123,12 @@ SkRect SkTileImageFilter::computeFastBounds(const SkRect& src) const { return fDstRect; } -SkFlattenable* SkTileImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkTileImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); SkRect src, dst; buffer.readRect(&src); buffer.readRect(&dst); - return Create(src, dst, common.getInput(0).get()); + return sk_sp<SkFlattenable>(Create(src, dst, common.getInput(0).get())); } void SkTileImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/SkXfermodeImageFilter.cpp b/src/effects/SkXfermodeImageFilter.cpp index db0b5e59bb..45c9f70568 100644 --- a/src/effects/SkXfermodeImageFilter.cpp +++ b/src/effects/SkXfermodeImageFilter.cpp @@ -37,11 +37,11 @@ SkXfermodeImageFilter::SkXfermodeImageFilter(sk_sp<SkXfermode> mode, , fMode(std::move(mode)) {} -SkFlattenable* SkXfermodeImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkXfermodeImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 2); sk_sp<SkXfermode> mode(buffer.readXfermode()); - return Make(std::move(mode), common.getInput(0).get(), - common.getInput(1).get(), &common.cropRect()).release(); + return Make(std::move(mode), common.getInput(0).get(), common.getInput(1).get(), + &common.cropRect()); } void SkXfermodeImageFilter::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/gradients/SkLinearGradient.cpp b/src/effects/gradients/SkLinearGradient.cpp index f521bd7024..e9fc865583 100644 --- a/src/effects/gradients/SkLinearGradient.cpp +++ b/src/effects/gradients/SkLinearGradient.cpp @@ -54,7 +54,7 @@ SkLinearGradient::SkLinearGradient(const SkPoint pts[2], const Descriptor& desc) , fEnd(pts[1]) { } -SkFlattenable* SkLinearGradient::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkLinearGradient::CreateProc(SkReadBuffer& buffer) { DescriptorScope desc; if (!desc.unflatten(buffer)) { return nullptr; @@ -63,7 +63,7 @@ SkFlattenable* SkLinearGradient::CreateProc(SkReadBuffer& buffer) { pts[0] = buffer.readPoint(); pts[1] = buffer.readPoint(); return SkGradientShader::MakeLinear(pts, desc.fColors, desc.fPos, desc.fCount, desc.fTileMode, - desc.fGradFlags, desc.fLocalMatrix).release(); + desc.fGradFlags, desc.fLocalMatrix); } void SkLinearGradient::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/gradients/SkRadialGradient.cpp b/src/effects/gradients/SkRadialGradient.cpp index 1312b36927..e666ac3cbd 100644 --- a/src/effects/gradients/SkRadialGradient.cpp +++ b/src/effects/gradients/SkRadialGradient.cpp @@ -60,7 +60,7 @@ SkShader::GradientType SkRadialGradient::asAGradient(GradientInfo* info) const { return kRadial_GradientType; } -SkFlattenable* SkRadialGradient::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkRadialGradient::CreateProc(SkReadBuffer& buffer) { DescriptorScope desc; if (!desc.unflatten(buffer)) { return nullptr; @@ -68,8 +68,7 @@ SkFlattenable* SkRadialGradient::CreateProc(SkReadBuffer& buffer) { const SkPoint center = buffer.readPoint(); const SkScalar radius = buffer.readScalar(); return SkGradientShader::MakeRadial(center, radius, desc.fColors, desc.fPos, desc.fCount, - desc.fTileMode, desc.fGradFlags, - desc.fLocalMatrix).release(); + desc.fTileMode, desc.fGradFlags, desc.fLocalMatrix); } void SkRadialGradient::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/gradients/SkSweepGradient.cpp b/src/effects/gradients/SkSweepGradient.cpp index f14035c526..ccc39d10f9 100644 --- a/src/effects/gradients/SkSweepGradient.cpp +++ b/src/effects/gradients/SkSweepGradient.cpp @@ -29,14 +29,14 @@ SkShader::GradientType SkSweepGradient::asAGradient(GradientInfo* info) const { return kSweep_GradientType; } -SkFlattenable* SkSweepGradient::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkSweepGradient::CreateProc(SkReadBuffer& buffer) { DescriptorScope desc; if (!desc.unflatten(buffer)) { return nullptr; } const SkPoint center = buffer.readPoint(); return SkGradientShader::MakeSweep(center.x(), center.y(), desc.fColors, desc.fPos, - desc.fCount, desc.fGradFlags, desc.fLocalMatrix).release(); + desc.fCount, desc.fGradFlags, desc.fLocalMatrix); } void SkSweepGradient::flatten(SkWriteBuffer& buffer) const { diff --git a/src/effects/gradients/SkTwoPointConicalGradient.cpp b/src/effects/gradients/SkTwoPointConicalGradient.cpp index d9fc39c3bc..f33dcc5a75 100644 --- a/src/effects/gradients/SkTwoPointConicalGradient.cpp +++ b/src/effects/gradients/SkTwoPointConicalGradient.cpp @@ -305,7 +305,7 @@ SkShader::GradientType SkTwoPointConicalGradient::asAGradient( return kConical_GradientType; } -SkFlattenable* SkTwoPointConicalGradient::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> SkTwoPointConicalGradient::CreateProc(SkReadBuffer& buffer) { DescriptorScope desc; if (!desc.unflatten(buffer)) { return nullptr; @@ -340,7 +340,7 @@ SkFlattenable* SkTwoPointConicalGradient::CreateProc(SkReadBuffer& buffer) { return SkGradientShader::MakeTwoPointConical(c1, r1, c2, r2, desc.fColors, desc.fPos, desc.fCount, desc.fTileMode, desc.fGradFlags, - desc.fLocalMatrix).release(); + desc.fLocalMatrix); } void SkTwoPointConicalGradient::flatten(SkWriteBuffer& buffer) const { |