diff options
| author |  Brian Osman <brianosman@google.com> | 2018-07-03 10:40:57 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-07-03 15:28:54 +0000 |
| commit | 34ec37458b0a6e157912e0ff6ee8e136885474b9 (patch) | |
| tree | 4effe9b5fd3f56fde4129b808a3c9eb21958c87d /src/effects | |
| parent | 630741c7c0ea8e504b04afd2f758232fb5c839a4 (diff) | |
Replace isGammaCorrect with isLinearlyBlended
We were using isGammaCorrect (presence of a color space) to trigger
rendering effects that should only apply when doing linear blending.
Rename and redefine that function to fix many of those issues.
In a few places, we really do care about the color space.
The big win here is text rendering, which is now the same on legacy
gl and glsrgb configs. Also left some comments about our desire to
do something smarter for text in the future.
Bug: skia:
Change-Id: I94106e95f5f81aaa0a28dbaccd65f5d94cf0de67
Reviewed-on: https://skia-review.googlesource.com/139109
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Diffstat (limited to 'src/effects')
| -rw-r--r-- | src/effects/SkHighContrastFilter.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/effects/SkHighContrastFilter.cpp b/src/effects/SkHighContrastFilter.cpp index 607033ef20..be6180a531 100644 --- a/src/effects/SkHighContrastFilter.cpp +++ b/src/effects/SkHighContrastFilter.cpp @@ -364,7 +364,7 @@ void GLHighContrastFilterEffect::emitCode(EmitArgs& args) { std::unique_ptr<GrFragmentProcessor> SkHighContrast_Filter::asFragmentProcessor( GrContext*, const GrColorSpaceInfo& csi) const { - bool linearize = !csi.isGammaCorrect(); + bool linearize = !csi.isLinearlyBlended(); return HighContrastFilterEffect::Make(fConfig, linearize); } #endif |