diff options
author | 2016-08-19 07:50:57 -0700 | |
---|---|---|
committer | 2016-08-19 07:50:57 -0700 | |
commit | e9fd0f8eafb68ff92aab257e9a7429eb29047327 (patch) | |
tree | 5c702741e37303530eb07743247175606e1c0086 /src/effects/gradients | |
parent | 429428660b247bb3ccb3195aa8b3abe3194d4d5b (diff) |
Return color shader instead of 2-color gradient when color count is 1
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005
Committed: https://skia.googlesource.com/skia/+/da082a5767d7edfd3abe74fc683392422565a606
Review-Url: https://codereview.chromium.org/2259823005
Diffstat (limited to 'src/effects/gradients')
-rw-r--r-- | src/effects/gradients/SkGradientShader.cpp | 37 |
1 files changed, 21 insertions, 16 deletions
diff --git a/src/effects/gradients/SkGradientShader.cpp b/src/effects/gradients/SkGradientShader.cpp index 6ffe56b9d4..78cdb80d55 100644 --- a/src/effects/gradients/SkGradientShader.cpp +++ b/src/effects/gradients/SkGradientShader.cpp @@ -742,18 +742,6 @@ static bool valid_grad(const SkColor colors[], const SkScalar pos[], int count, return nullptr != colors && count >= 1 && tileMode < (unsigned)SkShader::kTileModeCount; } -// assumes colors is SkColor* and pos is SkScalar* -#define EXPAND_1_COLOR(count) \ - SkColor tmp[2]; \ - do { \ - if (1 == count) { \ - tmp[0] = tmp[1] = colors[0]; \ - colors = tmp; \ - pos = nullptr; \ - count = 2; \ - } \ - } while (0) - static void desc_init(SkGradientShaderBase::Descriptor* desc, const SkColor colors[], const SkScalar pos[], int colorCount, SkShader::TileMode mode, uint32_t flags, const SkMatrix* localMatrix) { @@ -767,6 +755,18 @@ static void desc_init(SkGradientShaderBase::Descriptor* desc, desc->fLocalMatrix = localMatrix; } +// assumes colors is SkColor* and pos is SkScalar* +#define EXPAND_1_COLOR(count) \ + SkColor tmp[2]; \ + do { \ + if (1 == count) { \ + tmp[0] = tmp[1] = colors[0]; \ + colors = tmp; \ + pos = nullptr; \ + count = 2; \ + } \ + } while (0) + sk_sp<SkShader> SkGradientShader::MakeLinear(const SkPoint pts[2], const SkColor colors[], const SkScalar pos[], int colorCount, @@ -779,7 +779,9 @@ sk_sp<SkShader> SkGradientShader::MakeLinear(const SkPoint pts[2], if (!valid_grad(colors, pos, colorCount, mode)) { return nullptr; } - EXPAND_1_COLOR(colorCount); + if (1 == colorCount) { + return SkShader::MakeColorShader(colors[0]); + } SkGradientShaderBase::Descriptor desc; desc_init(&desc, colors, pos, colorCount, mode, flags, localMatrix); @@ -798,7 +800,9 @@ sk_sp<SkShader> SkGradientShader::MakeRadial(const SkPoint& center, SkScalar rad if (!valid_grad(colors, pos, colorCount, mode)) { return nullptr; } - EXPAND_1_COLOR(colorCount); + if (1 == colorCount) { + return SkShader::MakeColorShader(colors[0]); + } SkGradientShaderBase::Descriptor desc; desc_init(&desc, colors, pos, colorCount, mode, flags, localMatrix); @@ -826,7 +830,6 @@ sk_sp<SkShader> SkGradientShader::MakeTwoPointConical(const SkPoint& start, return SkShader::MakeEmptyShader(); } } - EXPAND_1_COLOR(colorCount); bool flipGradient = startRadius > endRadius; @@ -867,7 +870,9 @@ sk_sp<SkShader> SkGradientShader::MakeSweep(SkScalar cx, SkScalar cy, if (!valid_grad(colors, pos, colorCount, SkShader::kClamp_TileMode)) { return nullptr; } - EXPAND_1_COLOR(colorCount); + if (1 == colorCount) { + return SkShader::MakeColorShader(colors[0]); + } SkGradientShaderBase::Descriptor desc; desc_init(&desc, colors, pos, colorCount, SkShader::kClamp_TileMode, flags, localMatrix); |