diff options
| author |  James Zern <jzern@google.com> | 2016-11-09 19:22:46 -0800 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2016-11-16 00:03:26 +0000 |
| commit | 44e91c9638e7e31966d304635682e819cd9e440a (patch) | |
| tree | ee6953e064b5af4a5e68439fffcc7ffea9d5f284 /src/effects/gradients | |
| parent | f5a90e8a3f9350246236602d8ffc52d6ccf80a5e (diff) | |
LinearGradientContext::shade4_clamp: fix div by 0
getScaleX() may return 0; move division using it after a
SkScalarNearlyZero check and closer to its first use.
Change-Id: Ie209d46dc101213e20e90486651ee17570425bb8
Reviewed-on: https://skia-review.googlesource.com/4643
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Diffstat (limited to 'src/effects/gradients')
| -rw-r--r-- | src/effects/gradients/SkLinearGradient.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/effects/gradients/SkLinearGradient.cpp b/src/effects/gradients/SkLinearGradient.cpp index ea20595d3d..66accd8aa8 100644 --- a/src/effects/gradients/SkLinearGradient.cpp +++ b/src/effects/gradients/SkLinearGradient.cpp @@ -737,7 +737,6 @@ void SkLinearGradient::LinearGradientContext::shade4_clamp(int x, int y, SkPMCol } } const float dither[2] = { dither0, dither1 }; - const float invDx = 1 / dx; if (SkScalarNearlyZero(dx * count)) { // gradient is vertical const float pinFx = SkTPin(fx, 0.0f, 1.0f); @@ -750,6 +749,8 @@ void SkLinearGradient::LinearGradientContext::shade4_clamp(int x, int y, SkPMCol return; } + SkASSERT(0.f != dx); + const float invDx = 1 / dx; if (dx > 0) { if (fApplyAlphaAfterInterp) { this->shade4_dx_clamp<true, true>(dstC, count, fx, dx, invDx, dither); |