diff options
| author |  mtklein <mtklein@chromium.org> | 2016-07-14 11:02:09 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-07-14 11:02:09 -0700 |
| commit | 3296bee70d074bb8094b3229dbe12fa016657e90 (patch) | |
| tree | a6dc47b3805301e3416e3b9a2e361ac9d0217f15 /src/effects/gradients | |
| parent | 7cf36ccb441956e9e35bc4c9b08bdf8bafd9d4bb (diff) | |
Expand _01 half<->float limitation to _finite. Simplify.
It's become clear we need to sometimes deal with values <0 or >1.
I'm not yet convinced we care about NaN or +-inf.
We had some fairly clever tricks and optimizations here for NEON
and SSE. I've thrown them out in favor of a single implementation.
If we find the specializations mattered, we can certainly figure out
how to extend them to this new range/domain.
This happens to add a vectorized float -> half for ARMv7, which was
missing from the _01 version. (The SSE strategy was not portable to
platforms that flush denorm floats to zero.)
I've tested the full float range for FloatToHalf on my desktop and a 5x.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145663003
CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2145663003
Diffstat (limited to 'src/effects/gradients')
| -rw-r--r-- | src/effects/gradients/Sk4fGradientPriv.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/effects/gradients/Sk4fGradientPriv.h b/src/effects/gradients/Sk4fGradientPriv.h index ae6fe7ce46..68e95a63d9 100644 --- a/src/effects/gradients/Sk4fGradientPriv.h +++ b/src/effects/gradients/Sk4fGradientPriv.h @@ -143,11 +143,11 @@ struct DstTraits<DstType::F16, premul> { } static void store(const Sk4f& c, Type* dst) { - *dst = SkFloatToHalf_01(PM::apply(c)); + *dst = SkFloatToHalf_finite(PM::apply(c)); } static void store(const Sk4f& c, Type* dst, int n) { - sk_memset64(dst, SkFloatToHalf_01(PM::apply(c)), n); + sk_memset64(dst, SkFloatToHalf_finite(PM::apply(c)), n); } static void store4x(const Sk4f& c0, const Sk4f& c1, |