aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/effects/SkLightingImageFilter.cpp
diff options
context:
space:
mode:
authorGravatar senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-03-14 16:48:39 +0000
committerGravatar senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-03-14 16:48:39 +0000
commit29089179a66c06ef70da387111af75970f04ed53 (patch)
tree82b92dd3dbea630b3b64a55a66a4b501fd59f3fa /src/effects/SkLightingImageFilter.cpp
parent0ef0501baf615149d6d84398d7594cd89f6e928d (diff)
Revert "Implement support for expanding crop rects in image filters"
Breaking ImageFilterTests unit test. TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/196353021 git-svn-id: http://skia.googlecode.com/svn/trunk@13806 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/effects/SkLightingImageFilter.cpp')
-rw-r--r--src/effects/SkLightingImageFilter.cpp25
1 files changed, 14 insertions, 11 deletions
diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp
index 54bb1c890b..206be1b62d 100644
--- a/src/effects/SkLightingImageFilter.cpp
+++ b/src/effects/SkLightingImageFilter.cpp
@@ -946,17 +946,19 @@ bool SkDiffuseLightingImageFilter::onFilterImage(Proxy* proxy,
if (src.colorType() != kPMColor_SkColorType) {
return false;
}
- SkIRect bounds;
- if (!this->applyCropRect(ctx, proxy, src, &srcOffset, &bounds, &src)) {
+ SkAutoLockPixels alp(src);
+ if (!src.getPixels()) {
return false;
}
- if (bounds.width() < 2 || bounds.height() < 2) {
+ SkIRect bounds;
+ src.getBounds(&bounds);
+ bounds.offset(srcOffset);
+ if (!this->applyCropRect(&bounds, ctx.ctm())) {
return false;
}
- SkAutoLockPixels alp(src);
- if (!src.getPixels()) {
+ if (bounds.width() < 2 || bounds.height() < 2) {
return false;
}
@@ -1037,18 +1039,19 @@ bool SkSpecularLightingImageFilter::onFilterImage(Proxy* proxy,
if (src.colorType() != kPMColor_SkColorType) {
return false;
}
-
- SkIRect bounds;
- if (!this->applyCropRect(ctx, proxy, src, &srcOffset, &bounds, &src)) {
+ SkAutoLockPixels alp(src);
+ if (!src.getPixels()) {
return false;
}
- if (bounds.width() < 2 || bounds.height() < 2) {
+ SkIRect bounds;
+ src.getBounds(&bounds);
+ bounds.offset(srcOffset);
+ if (!this->applyCropRect(&bounds, ctx.ctm())) {
return false;
}
- SkAutoLockPixels alp(src);
- if (!src.getPixels()) {
+ if (bounds.width() < 2 || bounds.height() < 2) {
return false;
}