diff options
| author |  mtklein <mtklein@chromium.org> | 2014-12-18 13:29:54 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-12-18 13:29:54 -0800 |
| commit | 8aacf2085673f6302a43d590d4d2890789b87192 (patch) | |
| tree | ee82bfd1b0289e9f715ec86c7aed8e413c4e4de0 /src/effects/SkBlurMaskFilter.cpp | |
| parent | 152d42f628335b747c7b527cedbb69fe2dc3d3ee (diff) | |
Fill SkRRect::fType proactively.
I found no external mentions of SkRRect::kUnknown_Type.
Motivating race found by TSAN:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot/builds/48/steps/dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/801693003
Diffstat (limited to 'src/effects/SkBlurMaskFilter.cpp')
| -rw-r--r-- | src/effects/SkBlurMaskFilter.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/effects/SkBlurMaskFilter.cpp b/src/effects/SkBlurMaskFilter.cpp index b849c74805..b4c020f5e7 100644 --- a/src/effects/SkBlurMaskFilter.cpp +++ b/src/effects/SkBlurMaskFilter.cpp @@ -324,10 +324,6 @@ SkBlurMaskFilterImpl::filterRRectToNine(const SkRRect& rrect, const SkMatrix& ma NinePatch* patch) const { SkASSERT(patch != NULL); switch (rrect.getType()) { - case SkRRect::kUnknown_Type: - // Unknown should never be returned. - SkASSERT(false); - // Fall through. case SkRRect::kEmpty_Type: // Nothing to draw. return kFalse_FilterReturn; |