diff options
author | 2014-02-13 15:29:03 +0000 | |
---|---|---|
committer | 2014-02-13 15:29:03 +0000 | |
commit | bda591c739001b41d77048d680f81e05723cbc05 (patch) | |
tree | 80f0326a191c966bc34057e4011bdb3233bc2a50 /src/core | |
parent | b2d93a91222dac2edb3c19128fd58fa2e74272aa (diff) |
Revert of add peekPixels to SkCanvas and SkSurface (https://codereview.chromium.org/161733002/)
Reason for revert:
compile issues with gm/xfermodes3
Original issue's description:
> add peekPixels to SkCanvas and SkSurface
>
> clone of https://codereview.chromium.org/159723006/
>
> Committed: https://code.google.com/p/skia/source/detail?r=13427
R=jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/163823002
git-svn-id: http://skia.googlecode.com/svn/trunk@13428 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/core')
-rw-r--r-- | src/core/SkBitmapDevice.cpp | 14 | ||||
-rw-r--r-- | src/core/SkCanvas.cpp | 49 | ||||
-rw-r--r-- | src/core/SkDevice.cpp | 8 | ||||
-rw-r--r-- | src/core/SkPictureRecord.h | 3 |
4 files changed, 0 insertions, 74 deletions
diff --git a/src/core/SkBitmapDevice.cpp b/src/core/SkBitmapDevice.cpp index 374bef98c1..9dde6e172e 100644 --- a/src/core/SkBitmapDevice.cpp +++ b/src/core/SkBitmapDevice.cpp @@ -54,10 +54,6 @@ SkBitmapDevice::SkBitmapDevice(SkBitmap::Config config, int width, int height, b SkBitmapDevice::~SkBitmapDevice() { } -SkImageInfo SkBitmapDevice::imageInfo() const { - return fBitmap.info(); -} - void SkBitmapDevice::replaceBitmapBackendForRasterSurface(const SkBitmap& bm) { SkASSERT(bm.width() == fBitmap.width()); SkASSERT(bm.height() == fBitmap.height()); @@ -390,16 +386,6 @@ SkSurface* SkBitmapDevice::newSurface(const SkImageInfo& info) { return SkSurface::NewRaster(info); } -const void* SkBitmapDevice::peekPixels(SkImageInfo* info, size_t* rowBytes) { - if (fBitmap.getPixels() && fBitmap.asImageInfo(info)) { - if (rowBytes) { - *rowBytes = fBitmap.rowBytes(); - } - return fBitmap.getPixels(); - } - return NULL; -} - /////////////////////////////////////////////////////////////////////////////// bool SkBitmapDevice::filterTextFlags(const SkPaint& paint, TextFlags* flags) { diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp index f5e91ffc43..ed8274dc5d 100644 --- a/src/core/SkCanvas.cpp +++ b/src/core/SkCanvas.cpp @@ -992,55 +992,6 @@ SkSurface* SkCanvas::onNewSurface(const SkImageInfo& info) { return dev ? dev->newSurface(info) : NULL; } -SkImageInfo SkCanvas::imageInfo() const { - SkBaseDevice* dev = this->getDevice(); - if (dev) { - return dev->imageInfo(); - } else { - // TODO: need a real unknown for alphatype it seems. - SkAlphaType unknownAlphaType = kIgnore_SkAlphaType; - return SkImageInfo::Make(0, 0, kUnknown_SkColorType, unknownAlphaType); - } -} - -const void* SkCanvas::peekPixels(SkImageInfo* info, size_t* rowBytes) { - return this->onPeekPixels(info, rowBytes); -} - -const void* SkCanvas::onPeekPixels(SkImageInfo* info, size_t* rowBytes) { - SkBaseDevice* dev = this->getDevice(); - return dev ? dev->peekPixels(info, rowBytes) : NULL; -} - -SkAutoROCanvasPixels::SkAutoROCanvasPixels(SkCanvas* canvas) { - fAddr = canvas->peekPixels(&fInfo, &fRowBytes); - if (NULL == fAddr) { - fInfo = canvas->imageInfo(); - if (kUnknown_SkColorType == fInfo.colorType() || - !fBitmap.allocPixels(fInfo)) - { - return; // failure, fAddr is NULL - } - fBitmap.lockPixels(); - if (!canvas->readPixels(&fBitmap, 0, 0)) { - return; // failure, fAddr is NULL - } - fAddr = fBitmap.getPixels(); - fRowBytes = fBitmap.rowBytes(); - } - SkASSERT(fAddr); // success -} - -bool SkAutoROCanvasPixels::asROBitmap(SkBitmap* bitmap) const { - if (fAddr) { - return bitmap->installPixels(fInfo, const_cast<void*>(fAddr), fRowBytes, - NULL, NULL); - } else { - bitmap->reset(); - return false; - } -} - ///////////////////////////////////////////////////////////////////////////// void SkCanvas::internalDrawBitmap(const SkBitmap& bitmap, diff --git a/src/core/SkDevice.cpp b/src/core/SkDevice.cpp index 364b106dd8..9ce8b6b5df 100644 --- a/src/core/SkDevice.cpp +++ b/src/core/SkDevice.cpp @@ -65,12 +65,6 @@ SkMetaData& SkBaseDevice::getMetaData() { return *fMetaData; } -// TODO: should make this guy pure-virtual. -SkImageInfo SkBaseDevice::imageInfo() const { - return SkImageInfo::Make(this->width(), this->height(), - kUnknown_SkColorType, kIgnore_SkAlphaType); -} - const SkBitmap& SkBaseDevice::accessBitmap(bool changePixels) { const SkBitmap& bitmap = this->onAccessBitmap(); if (changePixels) { @@ -123,5 +117,3 @@ bool SkBaseDevice::readPixels(SkBitmap* bitmap, int x, int y, } SkSurface* SkBaseDevice::newSurface(const SkImageInfo&) { return NULL; } - -const void* SkBaseDevice::peekPixels(SkImageInfo*, size_t*) { return NULL; } diff --git a/src/core/SkPictureRecord.h b/src/core/SkPictureRecord.h index eaa5e73008..0df120b31a 100644 --- a/src/core/SkPictureRecord.h +++ b/src/core/SkPictureRecord.h @@ -221,9 +221,6 @@ public: protected: virtual SkSurface* onNewSurface(const SkImageInfo&) SK_OVERRIDE; - const void* onPeekPixels(SkImageInfo*, size_t*) SK_OVERRIDE { - return NULL; - } // Return fontmetrics.fTop,fBottom in topbot[0,1], after they have been // tweaked by paint.computeFastBounds(). |