Avoid double-destruction of Sk3DShaderContext-wrapped objects

Sk3DShaderContext creates its nested shader context on a SkArenaAlloc,
which handles destruction when going out of scope.

Hence, the explicit context dtor call in ~Sk3DShaderContext() is
incorrect (likely left over from before SkArenaAlloc).

BUG=chromium:787712

Change-Id: I176222e449151dcce532a839ef9587d06f61d297
Reviewed-on: https://skia-review.googlesource.com/77203
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Herb Derby <herb@google.com>

1 files changed, 2 insertions, 6 deletions

diff --git a/src/core/SkBlitter.cpp b/src/core/SkBlitter.cpp
index 6901511d4e..4bbd80d93f 100644
--- a/src/core/SkBlitter.cpp
+++ b/src/core/SkBlitter.cpp
@@ -715,11 +715,7 @@ public:
             }
         }
 
-        ~Sk3DShaderContext() override {
-            if (fProxyContext) {
-                fProxyContext->~Context();
-            }
-        }
+        ~Sk3DShaderContext() override = default;
 
         void set3DMask(const SkMask* mask) override { fMask = mask; }
 
@@ -790,7 +786,7 @@ public:
     private:
         // Unowned.
         const SkMask* fMask;
-        // Memory is unowned, but we need to call the destructor.
+        // Memory is unowned.
         Context*      fProxyContext;
         SkPMColor     fPMColor;