diff options
| author |  Mike Klein <mtklein@chromium.org> | 2016-10-26 15:32:26 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2016-10-26 20:58:56 +0000 |
| commit | e902f8dc7e111ede8b22cbd9bb74f326b0ce36fb (patch) | |
| tree | 95dc624b84d6d74cbf0f2081e5ceac97b02afdc4 /src/core/SkXfermode_proccoeff.h | |
| parent | 1285f413950910782d5439b5072ccfa14bdf80f7 (diff) | |
SkRasterPipelineBlitter simplifications
The main idea here is to simplify, mainly to reduce the number of SkRasterPipeline objects the blitter holds.
- Use SkBlendMode instead of SkXfermode, just store SkBlendMode.
- Fuse the shader and color filter together into one SkRasterPipeline
during blitter creation.
- I noticed all calls to append_load_d() and append_store() now have the same ctx argument, so I folded that through.
I'll be following up with more of this sort of refactoring... I think I can fold everything into a single SkRasterPipeline during blitter creation now, but I'll want to make sure I've got my ducks in a row for how that works with pipeline strength reduction (like skipping dst loads when drawing in Src mode).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4021
Change-Id: I88252ab8ad16f102c71bad871f8b6aec2fc1f226
Reviewed-on: https://skia-review.googlesource.com/4021
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'src/core/SkXfermode_proccoeff.h')
| -rw-r--r-- | src/core/SkXfermode_proccoeff.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/core/SkXfermode_proccoeff.h b/src/core/SkXfermode_proccoeff.h index 1e6cc482a6..357de4324c 100644 --- a/src/core/SkXfermode_proccoeff.h +++ b/src/core/SkXfermode_proccoeff.h @@ -53,8 +53,6 @@ public: SK_TO_STRING_OVERRIDE() SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkProcCoeffXfermode) - bool onAppendStages(SkRasterPipeline*) const override; - protected: void flatten(SkWriteBuffer& buffer) const override; |