diff options
author | 2013-04-29 17:40:33 +0000 | |
---|---|---|
committer | 2013-04-29 17:40:33 +0000 | |
commit | a0d91388bb6d3d18b7409dbc1654a4335b051ae5 (patch) | |
tree | 3aba1cbc1375a0602f1451ea80f87af1e7ab2e04 /src/core/SkXfermode.cpp | |
parent | c718b35bce895aa945fc479451156985206fdae1 (diff) |
Stop using mix() to implement hard-light in shader.
R=jvanverth@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/14541004
git-svn-id: http://skia.googlecode.com/svn/trunk@8910 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/core/SkXfermode.cpp')
-rw-r--r-- | src/core/SkXfermode.cpp | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/src/core/SkXfermode.cpp b/src/core/SkXfermode.cpp index 916e1b83a5..eb03ef9585 100644 --- a/src/core/SkXfermode.cpp +++ b/src/core/SkXfermode.cpp @@ -1135,12 +1135,16 @@ public: const char* final, const char* src, const char* dst) { - builder->fsCodeAppendf("\t\t%s.rgb = mix(2.0 * %s.rgb * %s.rgb, ", - final, src, dst); - builder->fsCodeAppendf("%s.aaa * %s.aaa - 2.0 * (%s.aaa - %s.rgb) * (%s.aaa - %s.rgb),", - src, dst, dst, dst, src, src); - builder->fsCodeAppendf("vec3(greaterThan(2.0 * %s.rgb, %s.aaa)));\n", - src, src); + static const char kComponents[] = {'r', 'g', 'b'}; + for (size_t i = 0; i < SK_ARRAY_COUNT(kComponents); ++i) { + char component = kComponents[i]; + builder->fsCodeAppendf("\t\tif (2.0 * %s.%c <= %s.a) {\n", src, component, src); + builder->fsCodeAppendf("\t\t\t%s.%c = 2.0 * %s.%c * %s.%c;\n", final, component, src, component, dst, component); + builder->fsCodeAppend("\t\t} else {\n"); + builder->fsCodeAppendf("\t\t\t%s.%c = %s.a * %s.a - 2.0 * (%s.a - %s.%c) * (%s.a - %s.%c);\n", + final, component, src, dst, dst, dst, component, src, src, component); + builder->fsCodeAppend("\t\t}\n"); + } builder->fsCodeAppendf("\t\t%s.rgb += %s.rgb * (1.0 - %s.a) + %s.rgb * (1.0 - %s.a);\n", final, src, dst, dst, src); } @@ -1367,10 +1371,7 @@ GrEffectRef* XferEffect::TestCreate(SkMWCRandom* rand, GrContext*, const GrDrawTargetCaps&, GrTexture*[]) { - int mode; - do { - mode = rand->nextRangeU(SkXfermode::kLastCoeffMode + 1, SkXfermode::kLastSeparableMode); - } while (mode == SkXfermode::kHardLight_Mode); + int mode = rand->nextRangeU(SkXfermode::kLastCoeffMode + 1, SkXfermode::kLastSeparableMode); static AutoEffectUnref gEffect(SkNEW_ARGS(XferEffect, (static_cast<SkXfermode::Mode>(mode)))); return CreateEffectRef(gEffect); |