aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/SkUtils.cpp
diff options
context:
space:
mode:
authorGravatar mtklein <mtklein@chromium.org>2015-07-27 11:08:28 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-07-27 11:08:28 -0700
commit58fd2c8af4fc4debbf3c9f3cf7783971982bd6dc (patch)
treee1bc172dafab6416e0de9a243ceaf4cd51257b5b /src/core/SkUtils.cpp
parentce2c5055cee5d5d3c9fc84c1b3eeed4b4d84a827 (diff)
Remove sk_memcpy32
It's only implemented on x86, where the exisiting benchmark says memcpy() is faster for all cases: Timer overhead: 24ns curr/maxrss loops min median mean max stddev samples config bench 10/10 MB 1 35.9µs 36.2µs 36.2µs 36.6µs 1% ▁▂▄▅▅▃█▄▄▅ nonrendering sk_memcpy32_100000 10/10 MB 13 2.27µs 2.28µs 2.28µs 2.29µs 0% █▄▃▅▃▁▃▅▁▄ nonrendering sk_memcpy32_10000 11/11 MB 677 91.6ns 95.9ns 94.5ns 99.4ns 3% ▅▅▅▅▅█▁▁▁▁ nonrendering sk_memcpy32_1000 11/11 MB 1171 20ns 20.9ns 21.3ns 23.4ns 6% ▁▁▇▃▃▃█▇▃▃ nonrendering sk_memcpy32_100 11/11 MB 1952 14ns 14ns 14.3ns 15.2ns 3% ▁▁██▁▁▁▁▁▁ nonrendering sk_memcpy32_10 11/11 MB 5 33.6µs 33.7µs 34.1µs 35.2µs 2% ▆▇█▁▁▁▁▁▁▁ nonrendering memcpy32_memcpy_100000 11/11 MB 18 2.12µs 2.22µs 2.24µs 2.39µs 5% ▂█▄▇█▄▇▁▁▁ nonrendering memcpy32_memcpy_10000 11/11 MB 1112 87.3ns 87.3ns 89.1ns 93.7ns 3% ▄██▄▁▁▁▁▁▁ nonrendering memcpy32_memcpy_1000 11/11 MB 2124 12.8ns 13.3ns 13.5ns 14.8ns 6% ▁▁▁█▃▃█▇▃▃ nonrendering memcpy32_memcpy_100 11/11 MB 3077 9ns 9.41ns 9.52ns 10.2ns 4% ▃█▁█▃▃▃▃▃▃ nonrendering memcpy32_memcpy_10 (Why? One fewer thing to port to SkOpts.) BUG=skia:4117 Review URL: https://codereview.chromium.org/1256763003
Diffstat (limited to 'src/core/SkUtils.cpp')
-rw-r--r--src/core/SkUtils.cpp14
1 files changed, 0 insertions, 14 deletions
diff --git a/src/core/SkUtils.cpp b/src/core/SkUtils.cpp
index 33ea4db47c..afd523d369 100644
--- a/src/core/SkUtils.cpp
+++ b/src/core/SkUtils.cpp
@@ -109,10 +109,6 @@ static void sk_memset32_portable(uint32_t dst[], uint32_t value, int count) {
}
}
-static void sk_memcpy32_portable(uint32_t dst[], const uint32_t src[], int count) {
- memcpy(dst, src, count * sizeof(uint32_t));
-}
-
namespace {
// These three methods technically need external linkage to be passed as template parameters.
// Since they can't be static, we hide them in an anonymous namespace instead.
@@ -127,11 +123,6 @@ SkMemset32Proc choose_memset32() {
return proc ? proc : sk_memset32_portable;
}
-SkMemcpy32Proc choose_memcpy32() {
- SkMemcpy32Proc proc = SkMemcpy32GetPlatformProc();
- return proc ? proc : sk_memcpy32_portable;
-}
-
} // namespace
void sk_memset16_large(uint16_t dst[], uint16_t value, int count) {
@@ -144,11 +135,6 @@ void sk_memset32_large(uint32_t dst[], uint32_t value, int count) {
proc.get()(dst, value, count);
}
-void sk_memcpy32(uint32_t dst[], const uint32_t src[], int count) {
- SK_DECLARE_STATIC_LAZY_FN_PTR(SkMemcpy32Proc, proc, choose_memcpy32);
- proc.get()(dst, src, count);
-}
-
///////////////////////////////////////////////////////////////////////////////
/* 0xxxxxxx 1 total