diff options
author | Mike Reed <reed@google.com> | 2017-09-15 11:37:15 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-09-15 18:46:45 +0000 |
commit | 49f1f34438d3431f6d7e32847accd2ba96948a73 (patch) | |
tree | c4e0342c3350c546573fb2add99597e92c9ca66c /src/core/SkStream.cpp | |
parent | 226e2032e8e37068a409aeb37aac79608fbd315d (diff) |
use unique_ptr for stream api
Bug: skia:6888
Change-Id: I3459b4913982a7cae1c0061697c82cc65ad9a2d8
Reviewed-on: https://skia-review.googlesource.com/26740
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Diffstat (limited to 'src/core/SkStream.cpp')
-rw-r--r-- | src/core/SkStream.cpp | 31 |
1 files changed, 23 insertions, 8 deletions
diff --git a/src/core/SkStream.cpp b/src/core/SkStream.cpp index 139a72f7ca..bc638c249a 100644 --- a/src/core/SkStream.cpp +++ b/src/core/SkStream.cpp @@ -15,6 +15,14 @@ #include "SkOSFile.h" #include "SkTypes.h" +#ifdef SK_SUPPORT_LEGACY_STREAM_API +#define DUP_NAME duplicate +#define FORK_NAME fork +#else +#define DUP_NAME onDuplicate +#define FORK_NAME onFork +#endif + /////////////////////////////////////////////////////////////////////////////// @@ -216,7 +224,7 @@ bool SkFILEStream::rewind() { return true; } -SkStreamAsset* SkFILEStream::duplicate() const { +SkStreamAsset* SkFILEStream::DUP_NAME() const { // TODO: fOriginalOffset instead of 0. return new SkFILEStream(fFILE, fSize, 0, fOriginalOffset); } @@ -234,7 +242,7 @@ bool SkFILEStream::move(long offset) { return this->seek(fOffset + offset); } -SkStreamAsset* SkFILEStream::fork() const { +SkStreamAsset* SkFILEStream::FORK_NAME() const { return new SkFILEStream(fFILE, fSize, fOffset, fOriginalOffset); } @@ -342,7 +350,14 @@ bool SkMemoryStream::rewind() { return true; } -SkMemoryStream* SkMemoryStream::duplicate() const { return new SkMemoryStream(fData); } +#ifdef SK_SUPPORT_LEGACY_STREAM_API +SkMemoryStream* SkMemoryStream::duplicate() const +#else +SkMemoryStream* SkMemoryStream::onDuplicate() const +#endif +{ + return new SkMemoryStream(fData); +} size_t SkMemoryStream::getPosition() const { return fOffset; @@ -359,7 +374,7 @@ bool SkMemoryStream::move(long offset) { return this->seek(fOffset + offset); } -SkMemoryStream* SkMemoryStream::fork() const { +SkMemoryStream* SkMemoryStream::FORK_NAME() const { std::unique_ptr<SkMemoryStream> that(this->duplicate()); that->seek(fOffset); return that.release(); @@ -731,7 +746,7 @@ public: return true; } - SkBlockMemoryStream* duplicate() const override { + SkBlockMemoryStream* DUP_NAME() const override { return new SkBlockMemoryStream(fBlockMemory, fSize); } @@ -760,12 +775,12 @@ public: return seek(fOffset + offset); } - SkBlockMemoryStream* fork() const override { - std::unique_ptr<SkBlockMemoryStream> that(this->duplicate()); + SkBlockMemoryStream* FORK_NAME() const override { + SkBlockMemoryStream* that = this->DUP_NAME(); that->fCurrent = this->fCurrent; that->fOffset = this->fOffset; that->fCurrentOffset = this->fCurrentOffset; - return that.release(); + return that; } size_t getLength() const override { |