aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/SkScan_Path.cpp
diff options
context:
space:
mode:
authorGravatar Mike Reed <reed@google.com>2018-02-15 11:17:56 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-02-15 17:14:19 +0000
commit36c0b57698a2e1fd181e5f1569fbf70cd695e9b8 (patch)
tree471296ebdf463a74a681373f2747434520330c19 /src/core/SkScan_Path.cpp
parentacf939ab58774593b49b2335369241bacffa0598 (diff)
use safe increment for edge walker
Bug: oss-fuzz:6126 Change-Id: I8f6865cbbbfbe37acf940cc2d4ae93204ba7168d Reviewed-on: https://skia-review.googlesource.com/107783 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
Diffstat (limited to 'src/core/SkScan_Path.cpp')
-rw-r--r--src/core/SkScan_Path.cpp9
1 files changed, 7 insertions, 2 deletions
diff --git a/src/core/SkScan_Path.cpp b/src/core/SkScan_Path.cpp
index 6234afe873..9c20527fbc 100644
--- a/src/core/SkScan_Path.cpp
+++ b/src/core/SkScan_Path.cpp
@@ -15,6 +15,7 @@
#include "SkRasterClip.h"
#include "SkRectPriv.h"
#include "SkRegion.h"
+#include "SkSafe32.h"
#include "SkTemplates.h"
#include "SkTSort.h"
@@ -259,8 +260,12 @@ static void walk_convex_edges(SkEdge* prevHead, SkPath::FillType,
if (L < R) {
blitter->blitH(L, local_top, R - L);
}
- left += dLeft;
- rite += dRite;
+ // Either/both of these might overflow, since we perform this step even if
+ // (later) we determine that we are done with the edge, and so the computed
+ // left or rite edge will not be used (see update_edge). Use this helper to
+ // silence UBSAN when we perform the add.
+ left = Sk32_can_overflow_add(left, dLeft);
+ rite = Sk32_can_overflow_add(rite, dRite);
local_top += 1;
} while (--count >= 0);
}