diff options
| author |  Yuqian Li <liyuqian@google.com> | 2017-01-12 18:12:46 +0000 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-01-12 18:13:02 +0000 |
| commit | 90ee03b0d1778f37448dfd82d1f5cfbbec9f798f (patch) | |
| tree | 29483ccc49e34596b376d22d4c2ae2473f772010 /src/core/SkScan.h | |
| parent | a022e2d834254a4c91f8c87d277d5085192f0852 (diff) | |
Revert "Implement Analytic AA for General Paths (with Guard against Chrome)"
This reverts commit 89a0e72287e991cfa2f860f92fad545ca59defe1.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Implement Analytic AA for General Paths (with Guard against Chrome)
>
> I've set up a SK_SUPPORT_LEGACY_AAA flag to guard against Chromium layout tests. I also set that flag in this CL so theoretically this CL won't trigger any GM changes. I'll use this to verify my guard, and remove that flag and actually enables concave AAA in a future CL.
>
> When enabled, for most simple concave paths (e.g., rectangle stroke, rrect stroke, sawtooth, stars...), the Analytic AA achieves 1.3x-2x speedup, and they look much prettier. And they probably are the majority in our use cases by number. But they probably are not the majority by time cost; a single complicated path may cost 10x-100x more time to render than a rectangle stroke... For those complicated paths, we fall back to supersampling by default as we're likely to be 1.1-1.2x slower and the quality improvement is not visually significant. However, one can use gSkForceAnalyticAA to disable that fallback.
>
> BUG=skia:
>
> Change-Id: If9549a3acc4a187cfaf7eb51890c148da3083d31
> Reviewed-on: https://skia-review.googlesource.com/6091
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Yuqian Li <liyuqian@google.com>
>
TBR=caryclark@google.com,liyuqian@google.com,reed@google.com
BUG=skia:
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I13c05aaa1bcb14956bd0fe01bb404e41be75af22
Reviewed-on: https://skia-review.googlesource.com/6961
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Diffstat (limited to 'src/core/SkScan.h')
| -rw-r--r-- | src/core/SkScan.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/core/SkScan.h b/src/core/SkScan.h index d4fe48650f..24e008826d 100644 --- a/src/core/SkScan.h +++ b/src/core/SkScan.h @@ -23,11 +23,7 @@ class SkPath; */ typedef SkIRect SkXRect; -// Use this to check that we successfully guard the change against Chromium layout tests -#define SK_SUPPORT_LEGACY_AAA - extern std::atomic<bool> gSkUseAnalyticAA; -extern std::atomic<bool> gSkForceAnalyticAA; class AdditiveBlitter; |