diff options
| author |  mtklein <mtklein@chromium.org> | 2015-02-24 14:38:12 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-02-24 14:38:12 -0800 |
| commit | 86821b56704ebc0a1a6d1e5d1e329369ac797c98 (patch) | |
| tree | 4162e8b041740ad1e7a535105f1440637110655e /src/core/SkResourceCache.cpp | |
| parent | 7eeba2587760a0802fd2b90765b4fd0e5e895375 (diff) | |
SkTRacy<T> -> SkAtomic<T>
Like SkTRacy<T>, TSAN will not complain about these. Unlike SkTRacy<T>, TSAN
should not complain about these: SkAtomic<T> are threadsafe.
This should fix the races now suppressed in TSAN. As written, the memory
barriers we're using in SkPixelRef will be dumb but safe (really, dumbest
possible but safest possible). If we see a perf hit, we can follow up by
putting Ben and I in a room for a while, thinking about it really hard, and
using the minimum-strength safe memory barriers.
A refactor that steals a bit from the genID would also still be possible with
this approach.
BUG=chromium:437511
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot
Review URL: https://codereview.chromium.org/955803002
Diffstat (limited to 'src/core/SkResourceCache.cpp')
0 files changed, 0 insertions, 0 deletions