diff options
| author |  mtklein <mtklein@google.com> | 2016-09-02 06:51:57 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-09-02 06:51:57 -0700 |
| commit | df0e3ece70762fd4674e09e457e5accb4265995d (patch) | |
| tree | d8459246289e52ae2b18c83f7cbcc3799c4c5c5b /src/core/SkRecords.cpp | |
| parent | d9ee597ce06ede5eb87190f45473404a08d46e52 (diff) | |
Revert of Force SkPath::getConvexity() cache for thread safety. (patchset #1 id:1 of https://codereview.chromium.org/2300003003/ )
Reason for revert:
I don't see anything else in the roll that could have caused the diff.
Original issue's description:
> Force SkPath::getConvexity() cache for thread safety.
>
> I happened to stumble on this in a run of TSAN:
> https://luci-milo.appspot.com/swarming/task/30fffe9497dc6310/steps/dm/0/stdout
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300003003
>
> Committed: https://skia.googlesource.com/skia/+/d0634eeb565d706df2e148a33f137c6edf42bf2e
TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2303303002
Diffstat (limited to 'src/core/SkRecords.cpp')
| -rw-r--r-- | src/core/SkRecords.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/core/SkRecords.cpp b/src/core/SkRecords.cpp index 555f992369..81dd92f9ef 100644 --- a/src/core/SkRecords.cpp +++ b/src/core/SkRecords.cpp @@ -11,7 +11,6 @@ namespace SkRecords { PreCachedPath::PreCachedPath(const SkPath& path) : SkPath(path) { this->updateBoundsCache(); - (void)this->getConvexity(); #if 0 // Disabled to see if we ever really race on this. It costs time, chromium:496982. SkPathPriv::FirstDirection junk; (void)SkPathPriv::CheapComputeFirstDirection(*this, &junk); |