diff options
author | mtklein <mtklein@google.com> | 2016-07-22 10:20:52 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-07-22 10:20:52 -0700 |
commit | aa29b2732914ad65334540babc945ae8c93f9036 (patch) | |
tree | 08d814ee744085f9e250ad57130d7d6425de9921 /src/core/SkRasterPipeline.cpp | |
parent | 5bfee98c8cf59db8d71aa6672088b107f0abf8c9 (diff) |
Revert of Add SkRasterPipeline blitter. (patchset #18 id:340001 of https://codereview.chromium.org/2146413002/ )
Reason for revert:
Leaking the blitter
https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/7908/steps/test_skia%20on%20Ubuntu/logs/stdio
Original issue's description:
> Add SkRasterPipeline blitter.
>
> This is now pixel-exact with the existing sRGB SW impl as far as I've tested.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002
> CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/3011e337693a9786f62d8de9ac4b239ad6dbdaca
TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2178523002
Diffstat (limited to 'src/core/SkRasterPipeline.cpp')
-rw-r--r-- | src/core/SkRasterPipeline.cpp | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/src/core/SkRasterPipeline.cpp b/src/core/SkRasterPipeline.cpp index c50383af01..899142886c 100644 --- a/src/core/SkRasterPipeline.cpp +++ b/src/core/SkRasterPipeline.cpp @@ -22,23 +22,11 @@ void SkRasterPipeline::append(SkRasterPipeline::Fn body_fn, const void* body_ctx fTail.push_back({ &JustReturn, const_cast<void*>(tail_ctx) }); } -void SkRasterPipeline::extend(const SkRasterPipeline& src) { - SkASSERT(src.fBody.count() == src.fTail.count()); - - Fn body_fn = src.fBodyStart, - tail_fn = src.fTailStart; - for (int i = 0; i < src.fBody.count(); i++) { - this->append(body_fn, src.fBody[i].fCtx, - tail_fn, src.fTail[i].fCtx); - body_fn = src.fBody[i].fNext; - tail_fn = src.fTail[i].fNext; - } -} - -void SkRasterPipeline::run(size_t x, size_t n) { +void SkRasterPipeline::run(size_t n) { // It's fastest to start uninitialized if the compilers all let us. If not, next fastest is 0. Sk4f v; + size_t x = 0; while (n >= 4) { fBodyStart(fBody.begin(), x, v,v,v,v, v,v,v,v); x += 4; |