aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/SkPixelRef.cpp
diff options
context:
space:
mode:
authorGravatar mtklein <mtklein@chromium.org>2015-02-25 08:11:18 -0800
committerGravatar Commit bot <commit-bot@chromium.org>2015-02-25 08:11:18 -0800
commitfbe0edfec4fed2a09e12b049d527d280f16e75b3 (patch)
treef9e3b35c9b7d8a518c002507f013f665de9cda91 /src/core/SkPixelRef.cpp
parent88ec329b580a081d9d56cbcaad0ee46cb941c849 (diff)
fAddedToCache doesn't need to be atomic.
It's only ever read or set from non-threadsafe methods. BUG=skia: Review URL: https://codereview.chromium.org/960573002
Diffstat (limited to 'src/core/SkPixelRef.cpp')
-rw-r--r--src/core/SkPixelRef.cpp9
1 files changed, 4 insertions, 5 deletions
diff --git a/src/core/SkPixelRef.cpp b/src/core/SkPixelRef.cpp
index 560748c463..24ee4733cb 100644
--- a/src/core/SkPixelRef.cpp
+++ b/src/core/SkPixelRef.cpp
@@ -100,7 +100,7 @@ SkPixelRef::SkPixelRef(const SkImageInfo& info)
this->needsNewGenID();
fIsImmutable = false;
fPreLocked = false;
- fAddedToCache.store(false);
+ fAddedToCache = false;
}
@@ -116,7 +116,7 @@ SkPixelRef::SkPixelRef(const SkImageInfo& info, SkBaseMutex* mutex)
this->needsNewGenID();
fIsImmutable = false;
fPreLocked = false;
- fAddedToCache.store(false);
+ fAddedToCache = false;
}
SkPixelRef::~SkPixelRef() {
@@ -227,10 +227,9 @@ void SkPixelRef::callGenIDChangeListeners() {
fGenIDChangeListeners[i]->onChange();
}
- // TODO: SkAtomic could add "old_value = atomic.xchg(new_value)" to make this clearer.
- if (fAddedToCache.load()) {
+ if (fAddedToCache) {
SkNotifyBitmapGenIDIsStale(this->getGenerationID());
- fAddedToCache.store(false);
+ fAddedToCache = false;
}
}
// Listeners get at most one shot, so whether these triggered or not, blow them away.