diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-05-08 23:24:05 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-05-08 23:24:05 +0000 |
| commit | f97d65dc256111f1de6bbf3521c7cd3cf3e70f60 (patch) | |
| tree | 006f070e89ae52ae52ee96e4e148669cf691cd62 /src/core/SkPictureStateTree.h | |
| parent | 97f0b089da0d9c4fe8aa2532b5f61d2615f6bf65 (diff) | |
Fix rendering artifacts in pull-saveLayers-forward mode
This CL fixes 2 bugs in the pre-rendering of saveLayers:
1) The drawBitmapRect call wasn't occurring in device space so could sometimes be double transformed
2) The BBH op skipping in SkPicturePlayback could sometimes mess up the SkPictureStateTree's state
It also reduces the number of layers that are pre-rendered when a BBH is not in use.
Committed: http://code.google.com/p/skia/source/detail?r=14650
R=bsalomon@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/267293007
git-svn-id: http://skia.googlecode.com/svn/trunk@14659 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/core/SkPictureStateTree.h')
| -rw-r--r-- | src/core/SkPictureStateTree.h | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/src/core/SkPictureStateTree.h b/src/core/SkPictureStateTree.h index f9e187a0cb..da51a5b954 100644 --- a/src/core/SkPictureStateTree.h +++ b/src/core/SkPictureStateTree.h @@ -82,21 +82,6 @@ public: TODO: this might be better named nextOp */ uint32_t nextDraw(); - /** Peek at the currently queued up draw op's offset. Note that this can - be different then what 'nextDraw' would return b.c. it is - the offset of the next _draw_ op while 'nextDraw' can return - the offsets to saveLayer and clip ops while it is creating the proper - drawing context for the queued up draw op. - */ - uint32_t peekDraw(); - /** Stop trying to create the drawing context for the currently queued - up _draw_ operation and queue up the next one. This call returns - the offset of the skipped _draw_ operation. Obviously (since the - correct drawing context has not been established), the skipped - _draw_ operation should not be issued. Returns kDrawComplete if - the end of the draw operations is reached. - */ - uint32_t skipDraw(); static const uint32_t kDrawComplete = SK_MaxU32; Iterator() : fPlaybackMatrix(), fValid(false) { } bool isValid() const { return fValid; } |