diff options
author | joshualitt <joshualitt@google.com> | 2015-03-05 12:18:38 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-03-05 12:18:38 -0800 |
commit | a0865b4620cc614586a5c02f258da2436ed3ab2b (patch) | |
tree | cbba8cff17a70b6ba29cbb8b028ba26f2ba8b9fb /src/core/SkPictureRecorder.cpp | |
parent | c1e97b372e21edf9c7e45cfea0eca7f1a52fe9e5 (diff) |
Revert of Update SkPicture cull rects with RTree information (patchset #6 id:140001 of https://codereview.chromium.org/971803002/)
Reason for revert:
Might be breaking deps roll
Original issue's description:
> Update SkPicture cull rects with RTree information
>
> When computed, the RTree for an SkPicture will have a root
> bounds that reflects the best bounding information available,
> rather than the best estimate at the time the picture recorder
> is created. Given that creators frequently don't know ahead of
> time what will be drawn, the RTree bound is often tighter.
>
> Perf testing on Chrome indicates a small raster performance
> advantage. For upcoming painting changes in Chrome the
> performance advantage is much larger.
>
> BUG=
>
> Committed: https://skia.googlesource.com/skia/+/2dd3b6647dc726f36fd8774b3d0d2e83b493aeac
TBR=mtklein@google.com,schenney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/977413003
Diffstat (limited to 'src/core/SkPictureRecorder.cpp')
-rw-r--r-- | src/core/SkPictureRecorder.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/core/SkPictureRecorder.cpp b/src/core/SkPictureRecorder.cpp index 1972ad3341..42f8732c79 100644 --- a/src/core/SkPictureRecorder.cpp +++ b/src/core/SkPictureRecorder.cpp @@ -60,10 +60,6 @@ SkPicture* SkPictureRecorder::endRecordingAsPicture() { } else { SkRecordFillBounds(fCullRect, *fRecord, fBBH.get()); } - SkRect bbhBound = fBBH->getRootBound(); - SkASSERT((bbhBound.isEmpty() || fCullRect.contains(bbhBound)) - || (bbhBound.isEmpty() && fCullRect.isEmpty())); - fCullRect = bbhBound; } SkPicture* pict = SkNEW_ARGS(SkPicture, (fCullRect, fRecord, pictList, fBBH)); |