diff options
| author |  bungeman <bungeman@google.com> | 2014-10-03 07:55:58 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-10-03 07:55:58 -0700 |
| commit | 22edc8310cd57ab02155bfa6b2ddaf830556bcaf (patch) | |
| tree | d405da7a43956eb2037d3c35cb51d2db6fd3b265 /src/core/SkPictureRecord.h | |
| parent | 7f1ed835e90027f63fbb25d19fb71d128b13834d (diff) | |
Fix int16_t for glyphs, const glyphs, and clarify glyph loop.
Several places in the PDF code are using int16_t for glyphs. With
newer NotoSans fonts, all possible glyph ids are being used, so this
can lead to problems.
The PDF glyphs from text code returns the text for the glyphs if the
encoding is for glyphs. However, it returns this using an unsafe const
cast which is hiding possible bugs and preventing correct use of const
in other places.
The way the glyph loop in SkPDFDevice::drawPosText is written uses a
'--i' in the loop, which makes it appear this can loop forever. I don't
believe it can, but it is an unecessary code folding. We should also at
least assert the forward progress correctness here.
Review URL: https://codereview.chromium.org/626613002
Diffstat (limited to 'src/core/SkPictureRecord.h')
0 files changed, 0 insertions, 0 deletions