diff options
| author |  robertphillips <robertphillips@google.com> | 2014-06-10 09:23:06 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-06-10 09:23:06 -0700 |
| commit | 6de27127c4d50ef90b5435aefaeef47fa84b819d (patch) | |
| tree | 7f38d11e6c7cb9dd85da98757f4f2bc7605eb601 /src/core/SkPicturePlayback.cpp | |
| parent | f74f55aeb0ebca87d03a10b1ad0597e75039fba5 (diff) | |
Remove unused 'deepCopy' parameter
This is split out of https://codereview.chromium.org/316063005/ for clarity. Keeping in mind that SkPicture::FakeEndRecording is now only called from SkPictureRecorder, its deepCopy parameter is no longer necessary. This is b.c., given the new Picture recording semantics (where SkPictures can no longer be actively recording), cloning for thread safety only happens when an SkPicturePlayback has already been allocated (i.e., it happens in the SkPicturePlayback copy constructor.
R=scroggo@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/324093003
Diffstat (limited to 'src/core/SkPicturePlayback.cpp')
| -rw-r--r-- | src/core/SkPicturePlayback.cpp | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/core/SkPicturePlayback.cpp b/src/core/SkPicturePlayback.cpp index 63f2d7e8f9..d57e30eeb1 100644 --- a/src/core/SkPicturePlayback.cpp +++ b/src/core/SkPicturePlayback.cpp @@ -58,8 +58,7 @@ SkPicturePlayback::SkPicturePlayback(const SkPicture* picture, const SkPictInfo& SkPicturePlayback::SkPicturePlayback(const SkPicture* picture, const SkPictureRecord& record, - const SkPictInfo& info, - bool deepCopy) + const SkPictInfo& info) : fPicture(picture) , fInfo(info) { #ifdef SK_DEBUG_SIZE @@ -134,12 +133,8 @@ SkPicturePlayback::SkPicturePlayback(const SkPicture* picture, if (fPictureCount > 0) { fPictureRefs = SkNEW_ARRAY(const SkPicture*, fPictureCount); for (int i = 0; i < fPictureCount; i++) { - if (deepCopy) { - fPictureRefs[i] = pictures[i]->clone(); - } else { - fPictureRefs[i] = pictures[i]; - fPictureRefs[i]->ref(); - } + fPictureRefs[i] = pictures[i]; + fPictureRefs[i]->ref(); } } |