aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/SkPMFloat.h
diff options
context:
space:
mode:
authorGravatar mtklein <mtklein@chromium.org>2015-03-03 07:46:15 -0800
committerGravatar Commit bot <commit-bot@chromium.org>2015-03-03 07:46:15 -0800
commit60d2a32b2dbbaabf4a0c133c8d3ff5ad888b8e5e (patch)
treeb5f30fb2ea6ae04b1f5c60d943274fea2878c466 /src/core/SkPMFloat.h
parentcff10b21a9934afc540d121b493b204335829589 (diff)
Make SkPMFloats store floats in [0,255] instead of [0,1].
This pushes the cost of the *255 and *1/255 conversions onto only those code paths that need it. We're not doing it any more efficiently than can be done with Sk4f. In microbenchmark isolation, this is about a 15% speedup. BUG=skia: NOPRESUBMIT=true Review URL: https://codereview.chromium.org/973603002
Diffstat (limited to 'src/core/SkPMFloat.h')
-rw-r--r--src/core/SkPMFloat.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/core/SkPMFloat.h b/src/core/SkPMFloat.h
index 936487e842..b0cb3146c7 100644
--- a/src/core/SkPMFloat.h
+++ b/src/core/SkPMFloat.h
@@ -5,7 +5,7 @@
#include "SkColor.h"
#include "Sk4x.h"
-// A pre-multiplied color storing each component as a float.
+// A pre-multiplied color storing each component as a float in the range [0, 255].
class SK_STRUCT_ALIGN(16) SkPMFloat {
public:
// Normal POD copies and do-nothing initialization.
@@ -30,10 +30,10 @@ public:
void set(SkPMColor);
SkPMColor get() const; // May SkASSERT(this->isValid()). Some implementations may clamp.
- SkPMColor clamped() const; // Will clamp all values to [0,1], then SkASSERT(this->isValid()).
+ SkPMColor clamped() const; // Will clamp all values to [0, 255]. Then may assert isValid().
bool isValid() const {
- return this->a() >= 0 && this->a() <= 1
+ return this->a() >= 0 && this->a() <= 255
&& this->r() >= 0 && this->r() <= this->a()
&& this->g() >= 0 && this->g() <= this->a()
&& this->b() >= 0 && this->b() <= this->a();