diff options
| author |  sdefresne <sdefresne@chromium.org> | 2016-06-01 07:08:56 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-06-01 07:08:56 -0700 |
| commit | e3fa811657ecf4ab694d026752a81080c6b10611 (patch) | |
| tree | 59836ffdb94ac987cd68fb6270e5e3d21cd56273 /src/core/SkOpts.cpp | |
| parent | ba150cc283301a28693a18d4aa9d14b1a1616ab3 (diff) | |
[GN] Add support for disabling opts via SK_BUILD_NO_OPTS define.
When targetting iOS and using gyp to generate the build files, it is not
possible to select files to build depending on the architecture. Due to
that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS
was defined.
Since it is possible to select the correct optimised version when using
gn, this pessimisation is hurting the build. Introduce a new define to
disable the optimisation SK_BUILD_NO_OPTS. It will be used by Chromium
when building skia for iOS with gyp but not gn.
Define SK_BUILD_NO_OPTS along-side SK_BUILD_FOR_IOS for all files that
look like build configuration (Xcode projects, gyp configuration files,
public.bzl) in order to avoid introducing breakage on those builds.
BUG=607933
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2002423002
Review-Url: https://codereview.chromium.org/2002423002
Diffstat (limited to 'src/core/SkOpts.cpp')
| -rw-r--r-- | src/core/SkOpts.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/core/SkOpts.cpp b/src/core/SkOpts.cpp index c6ff43b532..6d3e6c9fea 100644 --- a/src/core/SkOpts.cpp +++ b/src/core/SkOpts.cpp @@ -84,8 +84,7 @@ namespace SkOpts { void Init_avx2() {} static void init() { - // TODO: Chrome's not linking _sse* opts on iOS simulator builds. Bug or feature? - #if defined(SK_CPU_X86) && !defined(SK_BUILD_FOR_IOS) + #if defined(SK_CPU_X86) && !defined(SK_BUILD_NO_OPTS) if (SkCpu::Supports(SkCpu::SSSE3)) { Init_ssse3(); } if (SkCpu::Supports(SkCpu::SSE41)) { Init_sse41(); } if (SkCpu::Supports(SkCpu::SSE42)) { Init_sse42(); } |