diff options
| author |  dvonbeck <dvonbeck@google.com> | 2016-07-08 08:59:47 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-07-08 08:59:47 -0700 |
| commit | 66ad44a3f1df2547981b97c51d24f6881ba328e0 (patch) | |
| tree | bc40d3cbc0f8559a6550d5a791791c41a6aa67fa /src/core/SkNormalSource.cpp | |
| parent | babc3de2ce7c2f7b32b1b6b9f36d2ac4a4d8dee1 (diff) | |
Fixed error when normal.z = 1 in GPUs with binary16 floats
Check failed in GPUs with low-precision floats since 0.9999 was too small a difference from 1 to be detected by a 16-bit float comparison. Changed it to 0.999 which fixed the issue and results in indistinguishable correct behavior.
BUG=skia:5499
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004
Review-Url: https://codereview.chromium.org/2124183004
Diffstat (limited to 'src/core/SkNormalSource.cpp')
| -rw-r--r-- | src/core/SkNormalSource.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/SkNormalSource.cpp b/src/core/SkNormalSource.cpp index 52bb4adaa7..03c1a3a80c 100644 --- a/src/core/SkNormalSource.cpp +++ b/src/core/SkNormalSource.cpp @@ -109,7 +109,7 @@ public: // transforming all the normals here! // If there's no x & y components, return (0, 0, +/- 1) instead to avoid division by 0 - fragBuilder->codeAppend( "if (abs(normal.z) > 0.9999) {"); + fragBuilder->codeAppend( "if (abs(normal.z) > 0.999) {"); fragBuilder->codeAppendf(" %s = normalize(vec4(0.0, 0.0, normal.z, 0.0));", args.fOutputColor); // Else, Normalizing the transformed X and Y, while keeping constant both Z and the |