diff options
author | mtklein <mtklein@chromium.org> | 2015-05-07 13:41:07 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-07 13:41:07 -0700 |
commit | c92c129ff85b05a714bd1bf921c02d5e14651f8b (patch) | |
tree | ea2f915b36a5f6abb746827a4a6f650d5ff13310 /src/core/SkMiniRecorder.cpp | |
parent | 2fbd4068bde6a9fb50341c0bdfbb8bf18b70d015 (diff) |
Sketch splitting SkPicture into an interface and SkBigPicture.
Adds small pictures for drawRect(), drawTextBlob(), and drawPath().
These cover about 89% of draw calls from Blink SKPs,
and about 25% of draw calls from our GMs.
SkPicture handles:
- serialization and deserialization
- unique IDs
Everything else is left to the subclasses:
- playback(), cullRect()
- hasBitmap(), hasText(), suitableForGPU(), etc.
- LayerInfo / AccelData if applicable.
The time to record a 1-op picture improves a good chunk
(2 mallocs to 1), and the time to record a 0-op picture
greatly improves (2 mallocs to none):
picture_overhead_draw: 450ns -> 350ns
picture_overhead_nodraw: 300ns -> 90ns
BUG=skia:
Review URL: https://codereview.chromium.org/1112523006
Diffstat (limited to 'src/core/SkMiniRecorder.cpp')
-rw-r--r-- | src/core/SkMiniRecorder.cpp | 103 |
1 files changed, 103 insertions, 0 deletions
diff --git a/src/core/SkMiniRecorder.cpp b/src/core/SkMiniRecorder.cpp new file mode 100644 index 0000000000..fab6253430 --- /dev/null +++ b/src/core/SkMiniRecorder.cpp @@ -0,0 +1,103 @@ +/* + * Copyright 2015 Google Inc. + * + * Use of this source code is governed by a BSD-style license that can be + * found in the LICENSE file. + */ + +#include "SkCanvas.h" +#include "SkLazyPtr.h" +#include "SkMiniRecorder.h" +#include "SkPicture.h" +#include "SkPictureCommon.h" +#include "SkRecordDraw.h" +#include "SkTextBlob.h" + +using namespace SkRecords; + +class SkEmptyPicture final : public SkPicture { +public: + void playback(SkCanvas*, AbortCallback*) const override { } + + size_t approximateBytesUsed() const override { return sizeof(*this); } + int approximateOpCount() const override { return 0; } + SkRect cullRect() const override { return SkRect::MakeEmpty(); } + bool hasText() const override { return false; } + int numSlowPaths() const override { return 0; } + bool willPlayBackBitmaps() const override { return false; } + bool suitableForGpuRasterization(GrContext*, const char**) const override { return true; } +}; +SK_DECLARE_STATIC_LAZY_PTR(SkEmptyPicture, gEmptyPicture); + +template <typename T> +class SkMiniPicture final : public SkPicture { +public: + SkMiniPicture(SkRect cull, T* op) : fCull(cull) { + memcpy(&fOp, op, sizeof(fOp)); // We take ownership of op's guts. + } + + void playback(SkCanvas* c, AbortCallback*) const override { + SkRecords::Draw(c, nullptr, nullptr, 0, nullptr)(fOp); + } + + size_t approximateBytesUsed() const override { return sizeof(*this); } + int approximateOpCount() const override { return 1; } + SkRect cullRect() const override { return fCull; } + bool hasText() const override { return SkTextHunter()(fOp); } + bool willPlayBackBitmaps() const override { return SkBitmapHunter()(fOp); } + + // TODO: These trivial implementations are not all correct for all types. + // But I suspect these will never be called on SkMiniPictures, so assert for now. + int numSlowPaths() const override { SkASSERT(false); return 0; } + bool suitableForGpuRasterization(GrContext*, const char**) const override { + SkASSERT(false); + return true; + } + +private: + SkRect fCull; + T fOp; +}; + + +SkMiniRecorder::SkMiniRecorder() : fState(State::kEmpty) {} +SkMiniRecorder::~SkMiniRecorder() { + // We've done something wrong if no one's called detachAsPicture(). + SkASSERT(fState == State::kEmpty); +} + +#define TRY_TO_STORE(Type, ...) \ + if (fState != State::kEmpty) { return false; } \ + fState = State::k##Type; \ + new (fBuffer.get()) Type(__VA_ARGS__); \ + return true + +bool SkMiniRecorder::drawRect(const SkRect& rect, const SkPaint& paint) { + TRY_TO_STORE(DrawRect, paint, rect); +} + +bool SkMiniRecorder::drawPath(const SkPath& path, const SkPaint& paint) { + TRY_TO_STORE(DrawPath, paint, path); +} + +bool SkMiniRecorder::drawTextBlob(const SkTextBlob* b, SkScalar x, SkScalar y, const SkPaint& p) { + TRY_TO_STORE(DrawTextBlob, p, b, x, y); +} +#undef TRY_TO_STORE + +#define CASE(Type) \ + case State::k##Type: \ + fState = State::kEmpty; \ + return SkNEW_ARGS(SkMiniPicture<Type>, (cull, reinterpret_cast<Type*>(fBuffer.get()))) + +SkPicture* SkMiniRecorder::detachAsPicture(const SkRect& cull) { + switch (fState) { + case State::kEmpty: return SkRef(gEmptyPicture.get()); + CASE(DrawPath); + CASE(DrawRect); + CASE(DrawTextBlob); + } + SkASSERT(false); + return NULL; +} +#undef CASE |