diff options
author | bungeman <bungeman@google.com> | 2016-09-16 06:24:20 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-09-16 06:24:20 -0700 |
commit | f93d71122e4fcfcdc674a0163455990b13855f2f (patch) | |
tree | b3713fad2da586bf997264247961c1a91453c383 /src/core/SkFontMgr.cpp | |
parent | f560ef86813f712eff70feb9b00b70d0fe92c3cd (diff) |
SkFontData to use smart pointers.
The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.
This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to
std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It
appears that no one outside Skia is currently using SkStream::NewfromFile
so this is a good time to update it as well.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002
Committed: https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c
Review-Url: https://codereview.chromium.org/2339273002
Diffstat (limited to 'src/core/SkFontMgr.cpp')
-rw-r--r-- | src/core/SkFontMgr.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/core/SkFontMgr.cpp b/src/core/SkFontMgr.cpp index 0f00667926..57f82b03ba 100644 --- a/src/core/SkFontMgr.cpp +++ b/src/core/SkFontMgr.cpp @@ -139,11 +139,11 @@ SkTypeface* SkFontMgr::createFromStream(SkStreamAsset* stream, const FontParamet return this->onCreateFromStream(stream, params); } -SkTypeface* SkFontMgr::createFromFontData(SkFontData* data) const { +SkTypeface* SkFontMgr::createFromFontData(std::unique_ptr<SkFontData> data) const { if (nullptr == data) { return nullptr; } - return this->onCreateFromFontData(data); + return this->onCreateFromFontData(std::move(data)); } // This implementation is temporary until it can be made pure virtual. @@ -152,10 +152,8 @@ SkTypeface* SkFontMgr::onCreateFromStream(SkStreamAsset* stream, const FontParam } // This implementation is temporary until it can be made pure virtual. -SkTypeface* SkFontMgr::onCreateFromFontData(SkFontData* data) const { - SkTypeface* ret = this->createFromStream(data->detachStream(), data->getIndex()); - delete data; - return ret; +SkTypeface* SkFontMgr::onCreateFromFontData(std::unique_ptr<SkFontData> data) const { + return this->createFromStream(data->detachStream().release(), data->getIndex()); } SkTypeface* SkFontMgr::createFromFile(const char path[], int ttcIndex) const { |