aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/SkData.cpp
diff options
context:
space:
mode:
authorGravatar mtklein <mtklein@chromium.org>2015-09-09 06:48:29 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-09-09 06:48:29 -0700
commita1254acdb344174e761f5061c820559dab64a74c (patch)
treee7337fb34009c082ae4887e0eb91e5027e100ba4 /src/core/SkData.cpp
parenta5783aeff042ccaf517e50dee3660a4925f5f694 (diff)
Port uses of SkLazyPtr to SkOncePtr.
This gives SkOncePtr a non-trivial destructor that uses std::default_delete by default. This is overrideable, as seen in SkColorTable. SK_DECLARE_STATIC_ONCE_PTR still just leaves its pointers hanging at EOP. BUG=skia: No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1322933005
Diffstat (limited to 'src/core/SkData.cpp')
-rw-r--r--src/core/SkData.cpp11
1 files changed, 3 insertions, 8 deletions
diff --git a/src/core/SkData.cpp b/src/core/SkData.cpp
index 9e65d2a32e..017c397bbf 100644
--- a/src/core/SkData.cpp
+++ b/src/core/SkData.cpp
@@ -6,8 +6,8 @@
*/
#include "SkData.h"
-#include "SkLazyPtr.h"
#include "SkOSFile.h"
+#include "SkOncePtr.h"
#include "SkReadBuffer.h"
#include "SkStream.h"
#include "SkWriteBuffer.h"
@@ -80,14 +80,9 @@ SkData* SkData::PrivateNewWithCopy(const void* srcOrNull, size_t length) {
///////////////////////////////////////////////////////////////////////////////
-// As a template argument these must have external linkage.
-SkData* sk_new_empty_data() { return new SkData(nullptr, 0, nullptr, nullptr); }
-namespace { void sk_unref_data(SkData* ptr) { return SkSafeUnref(ptr); } }
-
-SK_DECLARE_STATIC_LAZY_PTR(SkData, empty, sk_new_empty_data, sk_unref_data);
-
+SK_DECLARE_STATIC_ONCE_PTR(SkData, gEmpty);
SkData* SkData::NewEmpty() {
- return SkRef(empty.get());
+ return SkRef(gEmpty.get([]{return new SkData(nullptr, 0, nullptr, nullptr); }));
}
// assumes fPtr was allocated via sk_malloc