diff options
| author |  Matt Sarett <msarett@google.com> | 2016-10-27 12:44:18 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2016-10-27 18:07:09 +0000 |
| commit | b3d1c2ea48c4fa5afcb62d8fb09f04d15e88a9bc (patch) | |
| tree | bb262e80011a8424e98e19826e232490cfe1c6dd /src/core/SkColorSpace_ICC.cpp | |
| parent | 23d73ea5b45cef6cf66ebe912725c4dd947c4767 (diff) | |
Improve comments describing common sRGB curves
BUG=skia:5897
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4037
Change-Id: Id1253cc9b960aad47bc0f9b7e40f10830d46d98d
Reviewed-on: https://skia-review.googlesource.com/4037
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
Diffstat (limited to 'src/core/SkColorSpace_ICC.cpp')
| -rw-r--r-- | src/core/SkColorSpace_ICC.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/core/SkColorSpace_ICC.cpp b/src/core/SkColorSpace_ICC.cpp index b0563c8459..cba2ee1783 100644 --- a/src/core/SkColorSpace_ICC.cpp +++ b/src/core/SkColorSpace_ICC.cpp @@ -357,8 +357,8 @@ static SkGammas::Type parse_gamma(SkGammas::Data* outData, SkColorSpaceTransferF } if (26 == count) { - // The magic values were chosen because they match a very common LCMS sRGB - // gamma table. + // The magic values match a clever "minimum size" approach to representing sRGB. + // code.facebook.com/posts/411525055626587/under-the-hood-improving-facebook-photos if (0 == read_big_endian_u16((const uint8_t*) &table[0]) && 3062 == read_big_endian_u16((const uint8_t*) &table[6]) && 12824 == read_big_endian_u16((const uint8_t*) &table[12]) && @@ -371,7 +371,7 @@ static SkGammas::Type parse_gamma(SkGammas::Data* outData, SkColorSpaceTransferF if (4096 == count) { // The magic values were chosen because they match Nikon, Epson, and - // LCMS sRGB gamma tables (all of which use different rounding rules). + // lcms2 sRGB gamma tables (all of which use different rounding rules). if (0 == read_big_endian_u16((const uint8_t*) &table[0]) && 950 == read_big_endian_u16((const uint8_t*) &table[515]) && 3342 == read_big_endian_u16((const uint8_t*) &table[1025]) && |